Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1186893003: Revert "Run install-build-deps in the middle of 'fetch chromium'" (Closed)

Created:
5 years, 6 months ago by agable
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Run install-build-deps in the middle of 'fetch chromium'" This reverts commit 78624b6839337be8a2ca7e12017aa951ec25a0bd. The reason is that install-build-deps.sh isn't meant to be run on mac or windows, and this implementation ran it everywhere. TBR=dpranke@chromium.org BUG=229270 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M fetch.py View 3 chunks +2 lines, -7 lines 0 comments Download
M recipes/chromium.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
agable
5 years, 6 months ago (2015-06-15 21:56:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186893003/1
5 years, 6 months ago (2015-06-15 21:57:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295686
5 years, 6 months ago (2015-06-15 21:59:12 UTC) #4
Dirk Pranke
5 years, 6 months ago (2015-06-15 22:02:40 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698