Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: Source/wtf/ArrayBufferContents.h

Issue 1186863005: Add a ref-counted data holder to ArrayBufferContents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: type in ArrayBuffer::shareContentsWith Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/wtf/ArrayBufferContents.h
diff --git a/Source/wtf/ArrayBufferContents.h b/Source/wtf/ArrayBufferContents.h
index bc48d9c3b757e2b6a65441789f747433913891dc..d5b4fc304c7beb60549620322c4e9517f9c22962 100644
--- a/Source/wtf/ArrayBufferContents.h
+++ b/Source/wtf/ArrayBufferContents.h
@@ -29,6 +29,8 @@
#include "wtf/Assertions.h"
#include "wtf/Noncopyable.h"
+#include "wtf/RefPtr.h"
+#include "wtf/ThreadSafeRefCounted.h"
#include "wtf/WTF.h"
#include "wtf/WTFExport.h"
@@ -42,24 +44,31 @@ public:
DontInitialize
};
+ enum SharingType {
+ NotShared,
+ Shared,
+ };
+
ArrayBufferContents();
- ArrayBufferContents(unsigned numElements, unsigned elementByteSize, ArrayBufferContents::InitializationPolicy);
+ ArrayBufferContents(unsigned numElements, unsigned elementByteSize, SharingType isShared, ArrayBufferContents::InitializationPolicy);
// Use with care. data must be allocated with allocateMemory.
// ArrayBufferContents will take ownership of the data and free it (using freeMemory)
// upon destruction.
// This constructor will not call observer->StartObserving(), so it is a responsibility
// of the caller to make sure JS knows about external memory.
- ArrayBufferContents(void* data, unsigned sizeInBytes);
+ ArrayBufferContents(void* data, unsigned sizeInBytes, SharingType isShared);
~ArrayBufferContents();
- void clear();
+ void neuter();
- void* data() const { return m_data; }
- unsigned sizeInBytes() const { return m_sizeInBytes; }
+ void* data() const { return m_holder ? m_holder->data() : nullptr; }
+ unsigned sizeInBytes() const { return m_holder ? m_holder->sizeInBytes() : 0; }
+ bool isShared() const { return m_holder ? m_holder->isShared() : false; }
void transfer(ArrayBufferContents& other);
+ void shareWith(ArrayBufferContents& other);
void copyTo(ArrayBufferContents& other);
static void allocateMemory(size_t, InitializationPolicy, void*&);
@@ -71,8 +80,27 @@ public:
}
private:
- void* m_data;
- unsigned m_sizeInBytes;
+ class DataHolder : public ThreadSafeRefCounted<DataHolder> {
+ WTF_MAKE_NONCOPYABLE(DataHolder);
+ public:
+ DataHolder();
+ ~DataHolder();
+
+ void allocateNew(unsigned sizeInBytes, SharingType isShared, InitializationPolicy);
+ void adopt(void* data, unsigned sizeInBytes, SharingType isShared);
+ void copyMemoryTo(DataHolder& other);
+
+ void* data() const { return m_data; }
+ unsigned sizeInBytes() const { return m_sizeInBytes; }
+ bool isShared() const { return m_isShared == Shared; }
+
+ private:
+ void* m_data;
+ unsigned m_sizeInBytes;
+ SharingType m_isShared;
+ };
+
+ RefPtr<DataHolder> m_holder;
static AdjustAmountOfExternalAllocatedMemoryFunction s_adjustAmountOfExternalAllocatedMemoryFunction;
};

Powered by Google App Engine
This is Rietveld 408576698