Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: Source/wtf/ArrayBuffer.cpp

Issue 1186863005: Add a ref-counted data holder to ArrayBufferContents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: type in ArrayBuffer::shareContentsWith Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #include "config.h" 26 #include "config.h"
27 #include "wtf/ArrayBuffer.h" 27 #include "wtf/ArrayBuffer.h"
28 28
29 #include "wtf/ArrayBufferView.h" 29 #include "wtf/ArrayBufferView.h"
30 #include "wtf/RefPtr.h" 30 #include "wtf/RefPtr.h"
31 31
32 namespace WTF { 32 namespace WTF {
33 33
34 bool ArrayBuffer::transfer(ArrayBufferContents& result) 34 bool ArrayBuffer::transfer(ArrayBufferContents& result)
35 { 35 {
36 ASSERT(!isShared());
36 RefPtr<ArrayBuffer> keepAlive(this); 37 RefPtr<ArrayBuffer> keepAlive(this);
37 38
38 if (!m_contents.data()) { 39 if (!m_contents.data()) {
39 result.clear(); 40 result.neuter();
40 return false; 41 return false;
41 } 42 }
42 43
43 bool allViewsAreNeuterable = true; 44 bool allViewsAreNeuterable = true;
44 for (ArrayBufferView* i = m_firstView; i; i = i->m_nextView) { 45 for (ArrayBufferView* i = m_firstView; i; i = i->m_nextView) {
45 if (!i->isNeuterable()) 46 if (!i->isNeuterable())
46 allViewsAreNeuterable = false; 47 allViewsAreNeuterable = false;
47 } 48 }
48 49
49 if (allViewsAreNeuterable) { 50 if (allViewsAreNeuterable) {
50 m_contents.transfer(result); 51 m_contents.transfer(result);
51 } else { 52 } else {
52 m_contents.copyTo(result); 53 m_contents.copyTo(result);
53 if (!result.data()) 54 if (!result.data())
54 return false; 55 return false;
55 } 56 }
56 57
57 while (m_firstView) { 58 while (m_firstView) {
58 ArrayBufferView* current = m_firstView; 59 ArrayBufferView* current = m_firstView;
59 removeView(current); 60 removeView(current);
60 if (allViewsAreNeuterable || current->isNeuterable()) 61 if (allViewsAreNeuterable || current->isNeuterable())
61 current->neuter(); 62 current->neuter();
62 } 63 }
63 64
64 m_isNeutered = true; 65 m_isNeutered = true;
65 66
66 return true; 67 return true;
67 } 68 }
68 69
70 bool ArrayBuffer::shareContentsWith(ArrayBufferContents& result)
71 {
72 ASSERT(isShared());
73 RefPtr<ArrayBuffer> keepAlive(this);
74
75 if (!m_contents.data()) {
76 result.neuter();
77 return false;
78 }
79
80 m_contents.shareWith(result);
81 return true;
82 }
83
69 void ArrayBuffer::addView(ArrayBufferView* view) 84 void ArrayBuffer::addView(ArrayBufferView* view)
70 { 85 {
71 view->m_buffer = this; 86 view->m_buffer = this;
72 view->m_prevView = 0; 87 view->m_prevView = 0;
73 view->m_nextView = m_firstView; 88 view->m_nextView = m_firstView;
74 if (m_firstView) 89 if (m_firstView)
75 m_firstView->m_prevView = view; 90 m_firstView->m_prevView = view;
76 m_firstView = view; 91 m_firstView = view;
77 } 92 }
78 93
79 void ArrayBuffer::removeView(ArrayBufferView* view) 94 void ArrayBuffer::removeView(ArrayBufferView* view)
80 { 95 {
81 ASSERT(this == view->m_buffer); 96 ASSERT(this == view->m_buffer);
82 if (view->m_nextView) 97 if (view->m_nextView)
83 view->m_nextView->m_prevView = view->m_prevView; 98 view->m_nextView->m_prevView = view->m_prevView;
84 if (view->m_prevView) 99 if (view->m_prevView)
85 view->m_prevView->m_nextView = view->m_nextView; 100 view->m_prevView->m_nextView = view->m_nextView;
86 if (m_firstView == view) 101 if (m_firstView == view)
87 m_firstView = view->m_nextView; 102 m_firstView = view->m_nextView;
88 view->m_prevView = view->m_nextView = 0; 103 view->m_prevView = view->m_nextView = 0;
89 } 104 }
90 105
91 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698