Add a ref-counted data holder to ArrayBufferContents

Source/wtf/ArrayBufferContents.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 19 matching lines @@
 #include "wtf/Assertions.h"
 #include "wtf/PartitionAlloc.h"
 #include "wtf/Partitions.h"
 #include <string.h>
 
 namespace WTF {
 
 AdjustAmountOfExternalAllocatedMemoryFunction ArrayBufferContents::s_adjustAmountOfExternalAllocatedMemoryFunction;
 
 ArrayBufferContents::ArrayBufferContents()
-    : m_data(0)
-    , m_sizeInBytes(0) { }
+    : m_holder(adoptRef(new DataHolder())) { }
 
-ArrayBufferContents::ArrayBufferContents(unsigned numElements, unsigned elementByteSize, ArrayBufferContents::InitializationPolicy policy)
-    : m_data(0)
-    , m_sizeInBytes(0)
+ArrayBufferContents::ArrayBufferContents(unsigned numElements, unsigned elementByteSize, SharingType isShared, ArrayBufferContents::InitializationPolicy policy)
+    : m_holder(adoptRef(new DataHolder()))
 {
     // Do not allow 32-bit overflow of the total size.
+    unsigned totalSize = numElements * elementByteSize;
     if (numElements) {
-        unsigned totalSize = numElements * elementByteSize;
         if (totalSize / numElements != elementByteSize) {
-            m_data = 0;
             return;
         }
     }
-    allocateMemory(numElements * elementByteSize, policy, m_data);
-    m_sizeInBytes = numElements * elementByteSize;
+
+    m_holder->allocateNew(totalSize, isShared, policy);
 }
 
-ArrayBufferContents::ArrayBufferContents(void* data, unsigned sizeInBytes)
-    : m_data(data)
-    , m_sizeInBytes(sizeInBytes)
+ArrayBufferContents::ArrayBufferContents(
+    void* data, unsigned sizeInBytes, SharingType isShared)
+    : m_holder(adoptRef(new DataHolder()))
 {
-    if (!m_data) {
-        ASSERT(!m_sizeInBytes);
-        m_sizeInBytes = 0;
-        // Allow null data if size is 0 bytes, make sure m_data is valid pointer.
-        // (partitionAllocGeneric guarantees valid pointer for size 0)
-        allocateMemory(0, ZeroInitialize, m_data);
+    if (data) {
+        m_holder->adopt(data, sizeInBytes, isShared);
+    } else {
+        ASSERT(!sizeInBytes);
+        sizeInBytes = 0;
+        // Allow null data if size is 0 bytes, make sure data is valid pointer.
+        // (PartitionAlloc guarantees valid pointer for size 0)
+        m_holder->allocateNew(sizeInBytes, isShared, ZeroInitialize);
     }
 }
 
 ArrayBufferContents::~ArrayBufferContents()
 {
-    freeMemory(m_data, m_sizeInBytes);
-    clear();
 }
 
-void ArrayBufferContents::clear()
+void ArrayBufferContents::neuter()
 {
-    m_data = 0;
-    m_sizeInBytes = 0;
+    m_holder.clear();
 }
 
 void ArrayBufferContents::transfer(ArrayBufferContents& other)
 {
-    ASSERT(!other.m_data);
-    other.m_data = m_data;
-    other.m_sizeInBytes = m_sizeInBytes;
-    clear();
+    ASSERT(!other.m_holder->data());
+    other.m_holder = m_holder;

[kinuko, 2015/06/23 10:44:37]

Transfer used to mean transfering ownership and not having neuter() here feels a
bit weird.  I see that SharedArrayBuffer extends the definition of 'transfer',
but ArrayBuffer::transfer() still behaves in the same way as it used to for
non-shared one, while this one does not, which seems inconsistent.

Maybe just keeping the neutering code as is but add a explanatory comment (for
why we don't neuter() for shared one) would be enough?  Or could we use
different method name from 'transfer' to avoid confusion?

 }
 
 void ArrayBufferContents::copyTo(ArrayBufferContents& other)
 {
-    ASSERT(!other.m_sizeInBytes);
-    other.freeMemory(other.m_data, other.m_sizeInBytes);
-    allocateMemory(m_sizeInBytes, DontInitialize, other.m_data);
-    if (!other.m_data)
-        return;
-    memcpy(other.m_data, m_data, m_sizeInBytes);
-    other.m_sizeInBytes = m_sizeInBytes;
+    ASSERT(!m_holder->isShared() && !other.m_holder->isShared());
+    m_holder->copyMemoryTo(*other.m_holder);
 }
 
 void ArrayBufferContents::allocateMemory(size_t size, InitializationPolicy policy, void*& data)
 {
     if (s_adjustAmountOfExternalAllocatedMemoryFunction)
         s_adjustAmountOfExternalAllocatedMemoryFunction(static_cast<int>(size));
     data = partitionAllocGenericFlags(WTF::Partitions::bufferPartition(), PartitionAllocReturnNull, size);
     if (policy == ZeroInitialize && data)
         memset(data, '\0', size);
 }
 
 void ArrayBufferContents::freeMemory(void* data, size_t size)
 {
     partitionFreeGeneric(WTF::Partitions::bufferPartition(), data);
     if (s_adjustAmountOfExternalAllocatedMemoryFunction)
         s_adjustAmountOfExternalAllocatedMemoryFunction(-static_cast<int>(size));
 }
 
+ArrayBufferContents::DataHolder::DataHolder()
+    : m_data(nullptr)
+    , m_sizeInBytes(0)
+    , m_isShared(NotShared) { }
+
+ArrayBufferContents::DataHolder::~DataHolder()
+{
+    ArrayBufferContents::freeMemory(m_data, m_sizeInBytes);
+
+    m_data = nullptr;
+    m_sizeInBytes = 0;
+    m_isShared = NotShared;
+}
+
+void ArrayBufferContents::DataHolder::allocateNew(unsigned sizeInBytes, SharingType isShared, InitializationPolicy policy)
+{
+    ASSERT(!m_data);
+    void* data = nullptr;
+    allocateMemory(sizeInBytes, policy, data);
+    m_data = data;
+    m_sizeInBytes = sizeInBytes;
+    m_isShared = isShared;
+}
+
+void ArrayBufferContents::DataHolder::adopt(void* data, unsigned sizeInBytes, SharingType isShared)
+{
+    ASSERT(!m_data);
+    m_data = data;
+    m_sizeInBytes = sizeInBytes;
+    m_isShared = isShared;
+}
+
+void ArrayBufferContents::DataHolder::copyMemoryTo(DataHolder& other)
+{
+    ASSERT(!other.m_sizeInBytes);
+    ArrayBufferContents::freeMemory(other.m_data, other.m_sizeInBytes);
+    ArrayBufferContents::allocateMemory(m_sizeInBytes, DontInitialize, other.m_data);
+    if (!other.m_data)
+        return;
+    memcpy(other.m_data, m_data, m_sizeInBytes);
+    other.m_sizeInBytes = m_sizeInBytes;
+}
+
 } // namespace WTF