Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(199)

Issue 1186843003: Revert "Oilpan: fix build after r197063, move HitTestCache to the heap." (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
sof, Rick Byers
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Oilpan: fix build after r197063, move HitTestCache to the heap." This reverts commit da27f0bb45d96705a51c875f0bf59d82db5f46c2. The original HitTestCache change is being reverted due to it causing a flaky test failure while I investigate it. BUG=500514 TBR=sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M Source/core/layout/HitTestCache.h View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/core/layout/HitTestCache.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/layout/HitTestResult.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186843003/1
4 years, 10 months ago (2015-06-15 14:17:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2015-06-15 14:17:33 UTC) #4
Rick Byers
rubber stamp LGTM for revert
4 years, 10 months ago (2015-06-15 14:30:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186843003/1
4 years, 10 months ago (2015-06-15 14:31:52 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 14:32:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197115

Powered by Google App Engine
This is Rietveld 408576698