content/browser/renderer_host/render_widget_host_view_base_unittest.cc - Issue 1186843002: Change root bounds in RenderWidgetHostViewAuraTest.ParentMovementUpdatesScreenRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base_unittest.cc

Issue 1186843002: Change root bounds in RenderWidgetHostViewAuraTest.ParentMovementUpdatesScreenRect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | tools/valgrind/gtest_exclude/content_unittests.gtest.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base_unittest.cc b/content/browser/renderer_host/render_widget_host_view_base_unittest.cc

index 4d9314a7abda068ac93a13b7acb4dc508fc92dc4..8277d1f6f00d5fd97856303e3c8ce574e31b3276 100644

--- a/content/browser/renderer_host/render_widget_host_view_base_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base_unittest.cc

@@ -81,8 +81,7 @@ TEST(RenderWidgetHostViewBaseTest, OrientationTypeForMobile) {

}

-// Fails on memory bots on all platforms. http://crbug.com/499914

-TEST(RenderWidgetHostViewBaseTest, DISABLED_OrientationTypeForDesktop) {

+TEST(RenderWidgetHostViewBaseTest, OrientationTypeForDesktop) {

// On Desktop, the primary orientation is the first computed one so a test

// similar to OrientationTypeForMobile is not possible.

// Instead this test will only check one configuration and verify that the