Source/core/css/resolver/CSSToStyleMap.cpp - Issue 1186833003: Split up CSSPrimitiveValue::isString into isString and isCustomIdent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1186833003: Split up CSSPrimitiveValue::isString into isString and isCustomIdent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/CSSToStyleMap.cpp

diff --git a/Source/core/css/resolver/CSSToStyleMap.cpp b/Source/core/css/resolver/CSSToStyleMap.cpp

index ac5558604534413ef3d1a4b4ba0b460a9ffeb338..00482ebd63dab58ec9aa046889d64f5a859cf68c 100644

--- a/Source/core/css/resolver/CSSToStyleMap.cpp

+++ b/Source/core/css/resolver/CSSToStyleMap.cpp

@@ -367,7 +367,7 @@ CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal

if (value->isInitialValue())

return CSSTransitionData::initialProperty();

CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

- if (primitiveValue->isString())

+ if (primitiveValue->isCustomIdent())

return CSSTransitionData::TransitionProperty(primitiveValue->getStringValue());

if (primitiveValue->getValueID() == CSSValueAll)

return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionAll);

« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »