Source/core/css/FontFace.cpp - Issue 1186833003: Split up CSSPrimitiveValue::isString into isString and isCustomIdent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontFace.cpp

Issue 1186833003: Split up CSSPrimitiveValue::isString into isString and isCustomIdent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/FontFace.cpp

diff --git a/Source/core/css/FontFace.cpp b/Source/core/css/FontFace.cpp

index 3760985540155e93f8177cc8b95426d6acf9fcb2..e4265aa631eefdfb96b464849303283196492f3e 100644

--- a/Source/core/css/FontFace.cpp

+++ b/Source/core/css/FontFace.cpp

@@ -278,7 +278,7 @@ bool FontFace::setFamilyValue(CSSValueList* familyList)

CSSPrimitiveValue* familyValue = toCSSPrimitiveValue(familyList->item(0));

AtomicString family;

- if (familyValue->isString()) {

+ if (familyValue->isCustomIdent()) {

family = AtomicString(familyValue->getStringValue());

} else if (familyValue->isValueID()) {

// We need to use the raw text for all the generic family types, since @font-face is a way of actually

« no previous file with comments | « Source/core/css/CSSPrimitiveValue.h ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »