Split up CSSPrimitiveValue::isString into isString and isCustomIdent

Source/core/css/resolver/StyleBuilderConverter.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 112 matching lines @@
     case CSSValueWebkitPictograph:
         return FontDescription::PictographFamily;
     default:
         return FontDescription::NoFamily;
     }
 }
 
 static bool convertFontFamilyName(StyleResolverState& state, CSSPrimitiveValue* primitiveValue,
     FontDescription::GenericFamilyType& genericFamily, AtomicString& familyName)
 {
-    if (primitiveValue->isString()) {
+    if (primitiveValue->isCustomIdent()) {
         genericFamily = FontDescription::NoFamily;
         familyName = AtomicString(primitiveValue->getStringValue());
     } else if (state.document().settings()) {
         genericFamily = convertGenericFamily(primitiveValue->getValueID());
         familyName = state.fontBuilder().genericFontFamilyName(genericFamily);
     }
 
     return !familyName.isEmpty();
 }
 
@@ skipping 250 matching lines @@
 {
     // We accept the specification's grammar:
     // 'auto' | [ <integer> || <custom-ident> ] | [ span && [ <integer> || <custom-ident> ] ] | <custom-ident>
 
     GridPosition position;
 
     if (value->isPrimitiveValue()) {
         CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
         // We translate <custom-ident> to <string> during parsing as it
         // makes handling it more simple.
-        if (primitiveValue->isString()) {
+        if (primitiveValue->isCustomIdent()) {
             position.setNamedGridArea(primitiveValue->getStringValue());
             return position;
         }
 
         ASSERT(primitiveValue->getValueID() == CSSValueAuto);
         return position;
     }
 
     CSSValueList* values = toCSSValueList(value);
     ASSERT(values->length());
@@ skipping 10 matching lines @@
         ++it;
         currentValue = it != values->end() ? toCSSPrimitiveValue(it->get()) : 0;
     }
 
     if (currentValue && currentValue->isNumber()) {
         gridLineNumber = currentValue->getIntValue();
         ++it;
         currentValue = it != values->end() ? toCSSPrimitiveValue(it->get()) : 0;
     }
 
-    if (currentValue && currentValue->isString()) {
+    if (currentValue && currentValue->isCustomIdent()) {
         gridLineName = currentValue->getStringValue();
         ++it;
     }
 
     ASSERT(it == values->end());
     if (isSpanPosition)
         position.setSpanPosition(gridLineNumber, gridLineName);
     else
         position.setExplicitPosition(gridLineNumber, gridLineName);
 
@@ skipping 485 matching lines @@
     CSSValueList* valueList = toCSSValueList(value);
     coordinates.reserveInitialCapacity(valueList->length());
     for (auto& snapCoordinate : *valueList) {
         coordinates.uncheckedAppend(convertPosition(state, snapCoordinate.get()));
     }
 
     return coordinates;
 }
 
 } // namespace blink