Split up CSSPrimitiveValue::isString into isString and isCustomIdent

Split up CSSPrimitiveValue::isString into isString and isCustomIdent

This patch splits up CSSPrimitiveValue::isString, which currently checks
for either CSS_STRING (<string>) or CSS_CUSTOM_IDENT (<custom-ident>,
but also used for <family-name>), into two separate functions. This makes
it clearer which values we're dealing with.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197210

[Timothy Loh, 2015-06-16 01:44:23]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org, sashab@chromium.org

[sashab, 2015-06-16 03:59:18]

I understand what you're doing but why was it a single function in the first
place? I.e. why do you think the callsites still behave correctly with
IsCustomIdent()? Can the parameters at these callsites never be strings?

[Timothy Loh, 2015-06-16 04:20:03]

timloh@chromium.org changed reviewers:
+ rob.buis@samsung.com

[Timothy Loh, 2015-06-16 04:24:03]

On 2015/06/16 03:59:18, sashab wrote:
> I understand what you're doing but why was it a single function in the first
> place? I.e. why do you think the callsites still behave correctly with
> IsCustomIdent()? Can the parameters at these callsites never be strings?

These callsites will not have strings, while the other callers to toString that
I didn't touch won't have custom idents. Previously (several months ago) both
strings and custom idents were represented with string primitive values, and
maybe we just didn't update this properly when splitting these into separate
types.

[rwlbuis, 2015-06-16 14:12:13]

lgtm

[sashab, 2015-06-16 14:50:21]

Cool, thanks for the explanation, lgtm

[Timothy Loh, 2015-06-16 23:54:57]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-06-16 23:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1186833003/1

[commit-bot: I haz the power, 2015-06-17 00:00:43]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197210