Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: Source/modules/device_orientation/DeviceOrientationData.h

Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Initialize the constructor to be null Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/device_orientation/DeviceOrientationData.h
diff --git a/Source/modules/device_orientation/DeviceOrientationData.h b/Source/modules/device_orientation/DeviceOrientationData.h
index fca44c3659b49ea3d2ab8ee982f020ebd34739ad..be4639cd85446d019097585013801e694a0b09a8 100644
--- a/Source/modules/device_orientation/DeviceOrientationData.h
+++ b/Source/modules/device_orientation/DeviceOrientationData.h
@@ -26,6 +26,7 @@
#ifndef DeviceOrientationData_h
#define DeviceOrientationData_h
+#include "bindings/core/v8/Nullable.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -35,7 +36,7 @@ class WebDeviceOrientationData;
class DeviceOrientationData final : public GarbageCollected<DeviceOrientationData> {
public:
static DeviceOrientationData* create();
- static DeviceOrientationData* create(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute = false, bool absolute = false);
+ static DeviceOrientationData* create(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute = false);
static DeviceOrientationData* create(const WebDeviceOrientationData&);
DEFINE_INLINE_TRACE() { }
@@ -52,16 +53,12 @@ public:
private:
DeviceOrientationData();
- DeviceOrientationData(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute, bool absolute);
+ DeviceOrientationData(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute);
- bool m_canProvideAlpha;
- bool m_canProvideBeta;
- bool m_canProvideGamma;
- bool m_canProvideAbsolute;
- double m_alpha;
- double m_beta;
- double m_gamma;
- bool m_absolute;
+ Nullable<double> m_alpha;
+ Nullable<double> m_beta;
+ Nullable<double> m_gamma;
+ Nullable<bool> m_absolute;
};
} // namespace blink
« no previous file with comments | « Source/bindings/modules/v8/custom/custom.gypi ('k') | Source/modules/device_orientation/DeviceOrientationData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698