Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: Source/modules/device_orientation/DeviceOrientationEvent.cpp

Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/device_orientation/DeviceOrientationEvent.cpp
diff --git a/Source/modules/device_orientation/DeviceOrientationEvent.cpp b/Source/modules/device_orientation/DeviceOrientationEvent.cpp
index 50edaf4eab1d42e190b5f817c485947d0d9d114e..cd8ea30c4791c370355fdaefcb7de6cf83c138e6 100644
--- a/Source/modules/device_orientation/DeviceOrientationEvent.cpp
+++ b/Source/modules/device_orientation/DeviceOrientationEvent.cpp
@@ -45,13 +45,13 @@ DeviceOrientationEvent::DeviceOrientationEvent(const AtomicString& eventType, De
{
}
-void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, DeviceOrientationData* orientation)
+void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool* bubbles, bool* cancelable, double* alpha, double* beta, double* gamma, bool* absolute)
{
if (dispatched())
return;
- initEvent(type, bubbles, cancelable);
- m_orientation = orientation;
+ initEvent(type, bubbles ? *bubbles : false, cancelable ? *cancelable : false);
+ m_orientation = DeviceOrientationData::create(alpha, alpha ? *alpha : false, beta, beta ? *beta : false, gamma, gamma ? *gamma : false, absolute, absolute ? *absolute : false);
vivekg 2015/06/16 11:53:03 There is a bit of typo here: false should be actua
}
double DeviceOrientationEvent::alpha(bool& isNull) const

Powered by Google App Engine
This is Rietveld 408576698