Add %TypedArray% to proto chain

test/mjsunit/es6/built-in-accessor-names.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --harmony-tostring
 
 'use strict';
 
-function assertGetterName(expected, object, name) {
-  var descr = Object.getOwnPropertyDescriptor(object, name);
+function GetPropertyDescriptor(object, field, expectedDepth) {

[arv (Not doing code reviews), 2015/06/15 16:23:12]

getP...

+  for (var depth = 0; depth < expectedDepth; depth++) {
+    assertFalse(Object.hasOwnProperty(object, field));
+    object = object.__proto__;
+  }
+  return Object.getOwnPropertyDescriptor(object, field);
+}
+
+function assertGetterName(expected, object, name, expectedDepth) {
+  var descr = GetPropertyDescriptor(object, name, expectedDepth);
   assertSame(expected, descr.get.name);
 }
 
 
-function assertSetterName(expected, object, name) {
-  var descr = Object.getOwnPropertyDescriptor(object, name);
+function assertSetterName(expected, object, name, indirect) {
+  var descr = GetPropertyDescriptor(object, name);
   assertSame(expected, descr.set.name);
 }
 
 
 assertGetterName('get byteLength', ArrayBuffer.prototype, 'byteLength');
 assertGetterName('get size', Set.prototype, 'size');
 assertGetterName('get size', Map.prototype, 'size');
 
 
 let typedArrays = [
   Uint8Array,
   Int8Array,
   Uint16Array,
   Int16Array,
   Uint32Array,
   Int32Array,
   Float32Array,
   Float64Array,
   Uint8ClampedArray
 ];
 
 for (let f of typedArrays) {
-  assertGetterName('get buffer', f.prototype, 'buffer');
-  assertGetterName('get byteOffset', f.prototype, 'byteOffset');
-  assertGetterName('get byteLength', f.prototype, 'byteLength');
-  assertGetterName('get length', f.prototype, 'length');
-  assertGetterName('get [Symbol.toStringTag]', f.prototype, Symbol.toStringTag);
+  assertGetterName('get buffer', f.prototype, 'buffer', 1);

[arv (Not doing code reviews), 2015/06/15 16:23:12]

I would probably just change this to `f.prototype.__proto__` or remove the loop
and just test Uint8Array.prototype.__proto__. There are already other tests
covering that these all have the correct prototype chain.

[Dan Ehrenberg, 2015/06/15 23:28:34]

Where are those tests?

[arv (Not doing code reviews), 2015/06/16 16:24:49]

I assume you have added tests that asserts that f.prototype.__proto__ ===
%TypedArray%.prototype somewhere?

[Dan Ehrenberg, 2015/06/16 22:38:22]

I'm not sure how I could add that test, as there's no direct way to get at
%TypedArray%.prototype besides through f.prototype.__proto__.

[arv (Not doing code reviews), 2015/06/16 22:48:42]

The way to do it is something like this:

var TypedArray = Uint8Array.__proto__;
var TypedArrayPrototype = TypedArray.prototype;

for (let f of typedArrays) {
  assertEquals(TypedArray, f.__proto__);
  assertEquals(TypedArrayPrototype, f.prototype.__proto__);
}

And then test the names by themselves.

assertGetterName('get byteOffset', TypedArrayPrototype, 'byteOffset')

+  assertGetterName('get byteOffset', f.prototype, 'byteOffset', 1);
+  assertGetterName('get byteLength', f.prototype, 'byteLength', 1);
+  assertGetterName('get length', f.prototype, 'length', 1);
+  assertGetterName('get [Symbol.toStringTag]', f.prototype, Symbol.toStringTag, 1);
 }
 
 
 assertGetterName('get buffer', DataView.prototype, 'buffer');
 assertGetterName('get byteOffset', DataView.prototype, 'byteOffset');
 assertGetterName('get byteLength', DataView.prototype, 'byteLength');
 
 
 assertGetterName('get __proto__', Object.prototype, '__proto__');
 assertSetterName('set __proto__', Object.prototype, '__proto__');