Add %TypedArray% to proto chain

src/typedarray.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 27 matching lines @@
 var MathMax;
 var MathMin;
 
 utils.Import(function(from) {
   MathMax = from.MathMax;
   MathMin = from.MathMin;
 });
 
 // --------------- Typed Arrays ---------------------
 
+function TypedArray() { }
+
+function TypedArray_GetBuffer() {
+  if (!%IsTypedArray(this)) {
+    throw MakeTypeError(kIncompatibleMethodReceiver, "TypedArray.buffer", this);
+  }
+  return %TypedArrayGetBuffer(this);
+}
+
+function TypedArray_GetByteLength() {
+  if (!%IsTypedArray(this)) {
+    throw MakeTypeError(kIncompatibleMethodReceiver, "TypedArray.buffer", this);

[adamk, 2015/06/13 00:49:38]

s/buffer/byteLength/

[Dan Ehrenberg, 2015/06/13 05:54:09]

Done.

+  }
+  return %_ArrayBufferViewGetByteLength(this);
+}
+
+function TypedArray_GetByteOffset() {
+  if (!%IsTypedArray(this)) {
+    throw MakeTypeError(kIncompatibleMethodReceiver, "TypedArray.buffer", this);

[adamk, 2015/06/13 00:49:38]

byteOffset

[Dan Ehrenberg, 2015/06/13 05:54:09]

Done.

+  }
+  return %_ArrayBufferViewGetByteOffset(this);
+}
+
+function TypedArray_GetLength() {
+  if (!%IsTypedArray(this)) {

[adamk, 2015/06/13 00:49:38]

I don't know if we can afford a runtime call for these trivial accessors. Would
blocking this change on fixing
https://code.google.com/p/v8/issues/detail?id=4182 be problematic?

Alternatively, we could add inlineable versions of this runtime function (they'd
be pretty trivial to create).

[Dan Ehrenberg, 2015/06/13 05:54:09]

This is sort of unrelated to v8:4182, except in that that bug probably also
needs an inlineable way to get the TypedArray tag to be done efficiently. I
think we should have both functions, and not rely on the latter to form a funny
way of checking the former.

Until then, I uploaded a new version of this patch. I won't submit this one
until that one is in, but code-wise there's no dependency, so I'll just leave
this out for review separately.

+    throw MakeTypeError(kIncompatibleMethodReceiver, "TypedArray.buffer", this);

[adamk, 2015/06/13 00:49:38]

length

[Dan Ehrenberg, 2015/06/13 05:54:09]

Done.

+  }
+  return %_TypedArrayGetLength(this);
+}
+
 macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)
 function NAMEConstructByArrayBuffer(obj, buffer, byteOffset, length) {
   if (!IS_UNDEFINED(byteOffset)) {
       byteOffset =
           $toPositiveInteger(byteOffset, kInvalidTypedArrayLength);
   }
   if (!IS_UNDEFINED(length)) {
       length = $toPositiveInteger(length, kInvalidTypedArrayLength);
   }
 
@@ skipping 80 matching lines @@
                IS_BOOLEAN(arg1) || IS_UNDEFINED(arg1)) {
       NAMEConstructByLength(this, arg1);
     } else {
       NAMEConstructByArrayLike(this, arg1);
     }
   } else {
     throw MakeTypeError(kConstructorNotFunction, "NAME")
   }
 }
 
-function NAME_GetBuffer() {
-  if (!(%_ClassOf(this) === 'NAME')) {
-    throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.buffer", this);
-  }
-  return %TypedArrayGetBuffer(this);
-}
-
-function NAME_GetByteLength() {
-  if (!(%_ClassOf(this) === 'NAME')) {
-    throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.byteLength", this);
-  }
-  return %_ArrayBufferViewGetByteLength(this);
-}
-
-function NAME_GetByteOffset() {
-  if (!(%_ClassOf(this) === 'NAME')) {
-    throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.byteOffset", this);
-  }
-  return %_ArrayBufferViewGetByteOffset(this);
-}
-
-function NAME_GetLength() {
-  if (!(%_ClassOf(this) === 'NAME')) {
-    throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.length", this);
-  }
-  return %_TypedArrayGetLength(this);
-}
-
 function NAMESubArray(begin, end) {
   if (!(%_ClassOf(this) === 'NAME')) {
     throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.subarray", this);
   }
   var beginInt = TO_INTEGER(begin);
   if (!IS_UNDEFINED(end)) {
     end = TO_INTEGER(end);
   }
 
   var srcLength = %_TypedArrayGetLength(this);
@@ skipping 127 matching lines @@
 
 function TypedArrayGetToStringTag() {
   if (!%IsTypedArray(this)) return;
   var name = %_ClassOf(this);
   if (IS_UNDEFINED(name)) return;
   return name;
 }
 
 // -------------------------------------------------------------------
 
+utils.InstallGetter(TypedArray.prototype, "buffer", TypedArray_GetBuffer);
+utils.InstallGetter(TypedArray.prototype, "byteOffset", TypedArray_GetByteOffset,

[adamk, 2015/06/13 00:49:38]

Nit: wrap at 80 chars (I don't know why we don't have a linter to catch this).
Same problem on some lines below.

[Dan Ehrenberg, 2015/06/13 05:54:09]

Done.

+                    DONT_ENUM | DONT_DELETE);
+utils.InstallGetter(TypedArray.prototype, "byteLength", TypedArray_GetByteLength,
+                    DONT_ENUM | DONT_DELETE);
+utils.InstallGetter(TypedArray.prototype, "length", TypedArray_GetLength,
+                    DONT_ENUM | DONT_DELETE);
+utils.InstallGetter(TypedArray.prototype, symbolToStringTag,
+                    TypedArrayGetToStringTag);
+utils.InstallFunctions(TypedArray.prototype, DONT_ENUM, [
+  "set", TypedArraySet
+]);
+
 macro SETUP_TYPED_ARRAY(ARRAY_ID, NAME, ELEMENT_SIZE)
   %SetCode(GlobalNAME, NAMEConstructor);
-  %FunctionSetPrototype(GlobalNAME, new GlobalObject());
+  %InternalSetPrototype(GlobalNAME, TypedArray);
+  %FunctionSetPrototype(GlobalNAME, new TypedArray());
+  %AddNamedProperty(GlobalNAME.prototype,
+                    "BYTES_PER_ELEMENT", ELEMENT_SIZE,
+                    READ_ONLY | DONT_ENUM | DONT_DELETE);
 
   %AddNamedProperty(GlobalNAME, "BYTES_PER_ELEMENT", ELEMENT_SIZE,
                     READ_ONLY | DONT_ENUM | DONT_DELETE);
   %AddNamedProperty(GlobalNAME.prototype,
                     "constructor", global.NAME, DONT_ENUM);
-  %AddNamedProperty(GlobalNAME.prototype,
-                    "BYTES_PER_ELEMENT", ELEMENT_SIZE,
-                    READ_ONLY | DONT_ENUM | DONT_DELETE);
-  utils.InstallGetter(GlobalNAME.prototype, "buffer", NAME_GetBuffer);
-  utils.InstallGetter(GlobalNAME.prototype, "byteOffset", NAME_GetByteOffset,
-                      DONT_ENUM | DONT_DELETE);
-  utils.InstallGetter(GlobalNAME.prototype, "byteLength", NAME_GetByteLength,
-                      DONT_ENUM | DONT_DELETE);
-  utils.InstallGetter(GlobalNAME.prototype, "length", NAME_GetLength,
-                      DONT_ENUM | DONT_DELETE);
-  utils.InstallGetter(GlobalNAME.prototype, symbolToStringTag,
-                      TypedArrayGetToStringTag);
   utils.InstallFunctions(GlobalNAME.prototype, DONT_ENUM, [
-    "subarray", NAMESubArray,
-    "set", TypedArraySet
+    "subarray", NAMESubArray

[adamk, 2015/06/13 00:49:38]

I'm guessing this is also blocked on issue 4182?

[Dan Ehrenberg, 2015/06/13 05:54:09]

Yep.

   ]);
 endmacro
 
 TYPED_ARRAYS(SETUP_TYPED_ARRAY)
 
 // --------------------------- DataView -----------------------------
 
 function DataViewConstructor(buffer, byteOffset, byteLength) { // length = 3
   if (%_IsConstructCall()) {
     // TODO(binji): support SharedArrayBuffers?
@@ skipping 116 matching lines @@
   "getUint32", DataViewGetUint32JS,
   "setUint32", DataViewSetUint32JS,
 
   "getFloat32", DataViewGetFloat32JS,
   "setFloat32", DataViewSetFloat32JS,
 
   "getFloat64", DataViewGetFloat64JS,
   "setFloat64", DataViewSetFloat64JS
 ]);
 
+// -------------------------------------------------------------------
+// Exports
+
+utils.Export(function(to) {
+  to.TypedArray = TypedArray;
+  to.TypedArrayPrototype = TypedArray.prototype;
+});
+
 })