Implement BodyStreamBuffer::create() from WebDataConsumerHandle

Implement BodyStreamBuffer::create() from WebDataConsumerHandle

This is used to replace BodyStreamBuffer with FetchDataConsumerHandle in upcoming CLs.

BUG=480746
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197248

[hiroshige, 2015-06-16 12:47:19]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2015-06-17 01:34:03]

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
File Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.cpp:153: ~WebDataConsumerHandleAdapter()
override { }
Do we need an empty destructor?

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.cpp:165:
Canceller(WebDataConsumerHandleAdapter* source) : m_source(source) { }
explicit

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
File Source/modules/fetch/BodyStreamBuffer.h (right):

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.h:78: static BodyStreamBuffer*
create(PassOwnPtr<WebDataConsumerHandle> /* handle */, const String&
failureMessage);
Why don't you implement this function?

[hiroshige, 2015-06-17 07:21:29]

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
File Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.cpp:153: ~WebDataConsumerHandleAdapter()
override { }
On 2015/06/17 01:34:02, yhirano wrote:
> Do we need an empty destructor?

Done.

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.cpp:165:
Canceller(WebDataConsumerHandleAdapter* source) : m_source(source) { }
On 2015/06/17 01:34:03, yhirano wrote:
> explicit

Done.

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
File Source/modules/fetch/BodyStreamBuffer.h (right):

https://codereview.chromium.org/1186713009/diff/20001/Source/modules/fetch/Bo...
Source/modules/fetch/BodyStreamBuffer.h:78: static BodyStreamBuffer*
create(PassOwnPtr<WebDataConsumerHandle> /* handle */, const String&
failureMessage);
On 2015/06/17 01:34:03, yhirano wrote:
> Why don't you implement this function?

Done.

[yhirano, 2015-06-17 08:07:35]

lgtm

[hiroshige, 2015-06-17 08:26:15]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2015-06-17 08:26:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1186713009/40001

[commit-bot: I haz the power, 2015-06-17 09:56:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197248