chrome/browser/autofill/autocheckout/whitelist_url.h - Issue 11867025: Download autocheckout whitelist and enable autocheckout for whitelisted sites only.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/autofill/autocheckout/whitelist_url.h

Issue 11867025: Download autocheckout whitelist and enable autocheckout for whitelisted sites only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix memory leak in AutofillMetricsTest. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/autocheckout/whitelist_manager_unittest.cc ('K') | « chrome/browser/autofill/autocheckout/whitelist_manager_unittest.cc ('k') | chrome/browser/autofill/autocheckout/whitelist_url.cc » ('j') | chrome/browser/autofill/form_structure.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOCHECKOUT_WHITELIST_URL_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUTOCHECKOUT_WHITELIST_URL_H_

	7

	8 class GURL;

	9

	10 namespace autofill {

	11 namespace autocheckout {

	12

	13 GURL GetAutocheckoutWhitelistUrl();

	14

	15 } // namespace autocheckout

	16 } // namespace autofill
	Ilya Sherman 2013/01/28 23:21:39 nit: It doesn't really seem worth defining a whole nit: It doesn't really seem worth defining a whole new header for just a single string constant + conversion to a GURL. I'd just inline all of this code into the anonymous namespace in whitelist_manager.cc benquan 2013/01/29 03:28:30 Done. Show quoted text On 2013/01/28 23:21:39, Ilya Sherman wrote: > nit: It doesn't really seem worth defining a whole new header for just a single > string constant + conversion to a GURL. I'd just inline all of this code into > the anonymous namespace in whitelist_manager.cc Done. Ilya Sherman 2013/01/29 06:15:09 This doesn't look to be done in the latest patch s Show quoted text On 2013/01/29 03:28:30, benquan wrote: > On 2013/01/28 23:21:39, Ilya Sherman wrote: > > nit: It doesn't really seem worth defining a whole new header for just a > single > > string constant + conversion to a GURL. I'd just inline all of this code into > > the anonymous namespace in whitelist_manager.cc > > Done. This doesn't look to be done in the latest patch set. benquan 2013/01/30 00:48:42 sorry, I missed this. Done Show quoted text On 2013/01/29 06:15:09, Ilya Sherman wrote: > On 2013/01/29 03:28:30, benquan wrote: > > On 2013/01/28 23:21:39, Ilya Sherman wrote: > > > nit: It doesn't really seem worth defining a whole new header for just a > > single > > > string constant + conversion to a GURL. I'd just inline all of this code > into > > > the anonymous namespace in whitelist_manager.cc > > > > Done. > > This doesn't look to be done in the latest patch set. sorry, I missed this. Done
	17

	18 #endif // CHROME_BROWSER_AUTOFILL_AUTOCHECKOUT_WHITELIST_URL_H_

	19

OLD	NEW