Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1186683008: Revert of Build Mojo apps in subdirectories, like application packages. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
sky, scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build Mojo apps in subdirectories, like application packages. (patchset #8 id:160001 of https://codereview.chromium.org/1180653002/) Reason for revert: This makes mojo_runner_unittests fail: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/3099/steps/mojo_runner_unittests/logs/stdio First failure repro steps and output: build/android/test_runner.py gtest -s mojo_runner_unittests --output-directory=/work/chrome-git/src/out/android_Debug --gtest_filter=ShellTestBaseTest.ConnectBasic [==========] Running 20 tests from 3 test cases. [----------] Global test environment set-up. [----------] 7 tests from ShellTestBaseTest [ RUN ] ShellTestBaseTest.ConnectBasic [ERROR:application_manager.cc(409)] Library not started because library path '/data/app/org.chromium.native_test-1/lib/arm/tracing/tracing.mojo' does not exist. [ERROR:application_manager.cc(409)] Library not started because library path '/data/data/org.chromium.native_test/app_test_apps/test_app/test_app.mojo' does not exist. ../../mojo/runner/shell_test_base_unittest.cc:96: Failure Value of: was_run Actual: false Expected: true ../../mojo/runner/shell_test_base_unittest.cc:97: Failure Value of: service.encountered_error() Actual: true Expected: false E 254.854s 6d40 Test terminated after 120 second timeout. Original issue's description: > Build Mojo apps in subdirectories, like application packages. > > Build all <foo>.mojo targets in a <foo> sub-directory. > Support resources bundled in mojo_native_application. > Remove mojo_application_package (now redundant). > Update hard-coded paths and simplify URL resolution code. > > Remove apps bundled in core_services from Mandoline.apk > (network service, surfaces service, view manager) > > This would help NetworkFetcher resolve app locations. > (Android apptests host the build dir on a local server) > (but apptests should instead bundle apps in an apk) > > BUG=498020 > TEST=Mojo runner and Mandoline still work (as much as they currently do :-/) > R=scottmg@chromium.org,sky@chromium.org > > Committed: https://crrev.com/e6439a2c956a2f09f40f10e8394a53437ad269ed > Cr-Commit-Position: refs/heads/master@{#334455} TBR=scottmg@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498020 Committed: https://crrev.com/ffbacd6a66de389df384c6cc3527e5958bbc01f6 Cr-Commit-Position: refs/heads/master@{#334478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -74 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/resource_provider/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 2 chunks +12 lines, -9 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/mojo_application_package.gni View 1 chunk +113 lines, -0 lines 0 comments Download
M mojo/public/mojo_application.gni View 7 chunks +21 lines, -36 lines 0 comments Download
M mojo/runner/BUILD.gn View 2 chunks +5 lines, -11 lines 0 comments Download
M mojo/runner/context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/url_resolver.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M mojo/runner/url_resolver_unittest.cc View 1 chunk +30 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Created Revert of Build Mojo apps in subdirectories, like application packages.
5 years, 6 months ago (2015-06-15 22:21:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186683008/1
5 years, 6 months ago (2015-06-15 22:24:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 22:27:12 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 22:28:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffbacd6a66de389df384c6cc3527e5958bbc01f6
Cr-Commit-Position: refs/heads/master@{#334478}

Powered by Google App Engine
This is Rietveld 408576698