DescriptionRevert of Build Mojo apps in subdirectories, like application packages. (patchset #8 id:160001 of https://codereview.chromium.org/1180653002/)
Reason for revert:
This makes mojo_runner_unittests fail:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/3099/steps/mojo_runner_unittests/logs/stdio
First failure repro steps and output:
build/android/test_runner.py gtest -s mojo_runner_unittests --output-directory=/work/chrome-git/src/out/android_Debug --gtest_filter=ShellTestBaseTest.ConnectBasic
[==========] Running 20 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 7 tests from ShellTestBaseTest
[ RUN ] ShellTestBaseTest.ConnectBasic
[ERROR:application_manager.cc(409)] Library not started because library path '/data/app/org.chromium.native_test-1/lib/arm/tracing/tracing.mojo' does not exist.
[ERROR:application_manager.cc(409)] Library not started because library path '/data/data/org.chromium.native_test/app_test_apps/test_app/test_app.mojo' does not exist.
../../mojo/runner/shell_test_base_unittest.cc:96: Failure
Value of: was_run
Actual: false
Expected: true
../../mojo/runner/shell_test_base_unittest.cc:97: Failure
Value of: service.encountered_error()
Actual: true
Expected: false
E 254.854s 6d40 Test terminated after 120 second timeout.
Original issue's description:
> Build Mojo apps in subdirectories, like application packages.
>
> Build all <foo>.mojo targets in a <foo> sub-directory.
> Support resources bundled in mojo_native_application.
> Remove mojo_application_package (now redundant).
> Update hard-coded paths and simplify URL resolution code.
>
> Remove apps bundled in core_services from Mandoline.apk
> (network service, surfaces service, view manager)
>
> This would help NetworkFetcher resolve app locations.
> (Android apptests host the build dir on a local server)
> (but apptests should instead bundle apps in an apk)
>
> BUG=498020
> TEST=Mojo runner and Mandoline still work (as much as they currently do :-/)
> R=scottmg@chromium.org,sky@chromium.org
>
> Committed: https://crrev.com/e6439a2c956a2f09f40f10e8394a53437ad269ed
> Cr-Commit-Position: refs/heads/master@{#334455}
TBR=scottmg@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498020
Committed: https://crrev.com/ffbacd6a66de389df384c6cc3527e5958bbc01f6
Cr-Commit-Position: refs/heads/master@{#334478}
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|