Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tool/sdk_expected_errors.txt

Issue 1186683005: dart:mirrors (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tool/input_sdk/private/js_mirrors.dart ('K') | « tool/input_sdk/private/js_mirrors.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index 8417abfd3fee09604594b1a4323393312a13e5f8..71f79a882f7e7ffcc9f6326ea87118c23c24d3c1 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -4,6 +4,12 @@ import 'dart:html' show Blob, Event, ImageData, Node, Window;
severe: line 92, column 1 of dart:js: [Message] File dart:indexed_db not found
import 'dart:indexed_db' show KeyRange;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 168, column 14 of dart:isolate: [DownCastComposite] IsolateNatives.spawnFunction(entryPoint, message, paused).then((msg) => new Isolate(msg[1], pauseCapability: msg[2], terminateCapability: msg[3])) (Future<dynamic>) will need runtime check to cast to type Future<Isolate>
+ return IsolateNatives.spawnFunction(entryPoint, message, paused)
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 234, column 14 of dart:isolate: [DownCastComposite] IsolateNatives.spawnUri(uri, args, message, paused).then((msg) => new Isolate(msg[1], pauseCapability: msg[2], terminateCapability: msg[3])) (Future<dynamic>) will need runtime check to cast to type Future<Isolate>
+ return IsolateNatives.spawnUri(uri, args, message, paused)
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: line 426, column 16 of dart:math: [DownCastImplicit] rnd32.remainder(max) (num) will need runtime check to cast to type int
result = rnd32.remainder(max); // % max;
^^^^^^^^^^^^^^^^^^^^
@@ -211,51 +217,6 @@ warning: line 89, column 14 of dart:_interceptors/js_string.dart: [DownCastCompo
severe: line 346, column 7 of dart:_interceptors/js_string.dart: [StaticTypeError] Type check failed: s += s (String) is not of type JSString
s += s;
^^^^^^
-warning: line 87, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 16)', source) (num) will need runtime check to cast to type int
- return JS('num', r'parseInt(#, 16)', source);
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 91, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 10)', source) (num) will need runtime check to cast to type int
- return JS('num', r'parseInt(#, 10)', source);
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 103, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 10)', source) (num) will need runtime check to cast to type int
- return JS('num', r'parseInt(#, 10)', source);
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 135, column 12 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, #)', source, radix) (num) will need runtime check to cast to type int
- return JS('num', r'parseInt(#, #)', source, radix);
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 159, column 16 of dart:_js_helper: [DownCastImplicit] result (num) will need runtime check to cast to type double
- return result;
- ^^^^^^
-warning: line 163, column 12 of dart:_js_helper: [DownCastImplicit] result (num) will need runtime check to cast to type double
- return result;
- ^^^^^^
-warning: line 250, column 15 of dart:_js_helper: [DownCastImplicit] 0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)) (num) will need runtime check to cast to type int
- a.add(0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)));
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 251, column 15 of dart:_js_helper: [DownCastImplicit] 0xdc00 + (i & 0x3ff) (num) will need runtime check to cast to type int
- a.add(0xdc00 + (i & 0x3ff));
- ^^^^^^^^^^^^^^^^^^^^
-warning: line 265, column 31 of dart:_js_helper: [DownCastComposite] charCodes (dynamic) will need runtime check to cast to type List<int>
- return _fromCharCodeApply(charCodes);
- ^^^^^^^^^
-warning: line 108, column 22 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] JS('JSExtendableArray|Null', r'#.exec(#)', _nativeRegExp, checkString(string)) (dynamic) will need runtime check to cast to type List<String>
- List<String> m = JS('JSExtendableArray|Null',
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 140, column 43 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] match (List<dynamic>) will need runtime check to cast to type List<String>
- return new _MatchImplementation(this, match);
- ^^^^^
-warning: line 152, column 43 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] match (List<dynamic>) will need runtime check to cast to type List<String>
- return new _MatchImplementation(this, match);
- ^^^^^
-warning: line 137, column 23 of dart:_js_helper/string_helper.dart: [DownCastComposite] pattern.allMatches(receiver) (dynamic) will need runtime check to cast to type Iterable<Match>
- for (Match match in pattern.allMatches(receiver)) {
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 168, column 14 of dart:isolate: [DownCastComposite] IsolateNatives.spawnFunction(entryPoint, message, paused).then((msg) => new Isolate(msg[1], pauseCapability: msg[2], terminateCapability: msg[3])) (Future<dynamic>) will need runtime check to cast to type Future<Isolate>
- return IsolateNatives.spawnFunction(entryPoint, message, paused)
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-warning: line 234, column 14 of dart:isolate: [DownCastComposite] IsolateNatives.spawnUri(uri, args, message, paused).then((msg) => new Isolate(msg[1], pauseCapability: msg[2], terminateCapability: msg[3])) (Future<dynamic>) will need runtime check to cast to type Future<Isolate>
- return IsolateNatives.spawnUri(uri, args, message, paused)
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
severe: line 452, column 28 of dart:_native_typed_data: [AnalyzerError] The getter 'length' is not defined for the class 'NativeTypedData'
if (length == list.length) {
^^^^^^
@@ -310,21 +271,21 @@ warning: line 357, column 29 of dart:_isolate_helper/isolate_serialization.dart:
warning: line 20, column 39 of dart:async/async_error.dart: [DownCastImplicit] errorHandler (Function) will need runtime check to cast to type (dynamic) → dynamic
return zone.registerUnaryCallback(errorHandler);
^^^^^^^^^^^^
-severe: line 211, column 38 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_next' is not defined for the class 'StreamSubscription<T>'
- assert(!identical(subscription._next, subscription));
- ^^^^^
-severe: line 209, column 20 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The method '_setRemoveAfterFiring' is not defined for the class 'StreamSubscription<T>'
- subscription._setRemoveAfterFiring();
- ^^^^^^^^^^^^^^^^^^^^^
-severe: line 207, column 36 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_next' is not defined for the class 'StreamSubscription<T>'
- assert(!identical(subscription._next, subscription));
- ^^^^^
severe: line 208, column 22 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_isFiring' is not defined for the class 'StreamSubscription<T>'
if (subscription._isFiring) {
^^^^^^^^^
severe: line 206, column 32 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_next' is not defined for the class 'StreamSubscription<T>'
if (identical(subscription._next, subscription)) return null;
^^^^^
+severe: line 209, column 20 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The method '_setRemoveAfterFiring' is not defined for the class 'StreamSubscription<T>'
+ subscription._setRemoveAfterFiring();
+ ^^^^^^^^^^^^^^^^^^^^^
+severe: line 207, column 36 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_next' is not defined for the class 'StreamSubscription<T>'
+ assert(!identical(subscription._next, subscription));
+ ^^^^^
+severe: line 211, column 38 of dart:async/broadcast_stream_controller.dart: [AnalyzerError] The getter '_next' is not defined for the class 'StreamSubscription<T>'
+ assert(!identical(subscription._next, subscription));
+ ^^^^^
warning: line 8, column 67 of dart:async/broadcast_stream_controller.dart: [DownCastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runtime check to cast to type _StreamControllerLifecycle<T>
_BroadcastStream(_StreamControllerLifecycle controller) : super(controller);
^^^^^^^^^^
@@ -1081,6 +1042,45 @@ warning: line 779, column 39 of dart:collection/splay_tree.dart: [DownCastCompos
warning: line 791, column 23 of dart:collection/splay_tree.dart: [DownCastComposite] object (Object) will need runtime check to cast to type E
int comp = _splay(object);
^^^^^^
+warning: line 87, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 16)', source) (num) will need runtime check to cast to type int
+ return JS('num', r'parseInt(#, 16)', source);
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 91, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 10)', source) (num) will need runtime check to cast to type int
+ return JS('num', r'parseInt(#, 10)', source);
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 103, column 18 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, 10)', source) (num) will need runtime check to cast to type int
+ return JS('num', r'parseInt(#, 10)', source);
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 135, column 12 of dart:_js_helper: [DownCastImplicit] JS('num', r'parseInt(#, #)', source, radix) (num) will need runtime check to cast to type int
+ return JS('num', r'parseInt(#, #)', source, radix);
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 159, column 16 of dart:_js_helper: [DownCastImplicit] result (num) will need runtime check to cast to type double
+ return result;
+ ^^^^^^
+warning: line 163, column 12 of dart:_js_helper: [DownCastImplicit] result (num) will need runtime check to cast to type double
+ return result;
+ ^^^^^^
+warning: line 250, column 15 of dart:_js_helper: [DownCastImplicit] 0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)) (num) will need runtime check to cast to type int
+ a.add(0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)));
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 251, column 15 of dart:_js_helper: [DownCastImplicit] 0xdc00 + (i & 0x3ff) (num) will need runtime check to cast to type int
+ a.add(0xdc00 + (i & 0x3ff));
+ ^^^^^^^^^^^^^^^^^^^^
+warning: line 265, column 31 of dart:_js_helper: [DownCastComposite] charCodes (dynamic) will need runtime check to cast to type List<int>
+ return _fromCharCodeApply(charCodes);
+ ^^^^^^^^^
+warning: line 108, column 22 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] JS('JSExtendableArray|Null', r'#.exec(#)', _nativeRegExp, checkString(string)) (dynamic) will need runtime check to cast to type List<String>
+ List<String> m = JS('JSExtendableArray|Null',
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 140, column 43 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] match (List<dynamic>) will need runtime check to cast to type List<String>
+ return new _MatchImplementation(this, match);
+ ^^^^^
+warning: line 152, column 43 of dart:_js_helper/regexp_helper.dart: [DownCastComposite] match (List<dynamic>) will need runtime check to cast to type List<String>
+ return new _MatchImplementation(this, match);
+ ^^^^^
+warning: line 137, column 23 of dart:_js_helper/string_helper.dart: [DownCastComposite] pattern.allMatches(receiver) (dynamic) will need runtime check to cast to type Iterable<Match>
+ for (Match match in pattern.allMatches(receiver)) {
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
severe: line 514, column 46 of dart:js: [AnalyzerError] The name 'Window' is not defined and cannot be used in an 'is' expression
|| o is Node || o is TypedData || o is Window) {
^^^^^^
@@ -1159,3 +1159,6 @@ warning: line 571, column 12 of dart:js: [DownCastImplicit] _getDartProxy(o, _DA
warning: line 574, column 12 of dart:js: [DownCastImplicit] _getDartProxy(o, _DART_OBJECT_PROPERTY_NAME, (o) => new JsObject._fromJs(o)) (Object) will need runtime check to cast to type JsObject
return _getDartProxy(o, _DART_OBJECT_PROPERTY_NAME,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+warning: line 171, column 10 of dart:mirrors: [DownCastImplicit] (tm as ClassMirror).originalDeclaration (TypeMirror) will need runtime check to cast to type ClassMirror
+ return (tm as ClassMirror).originalDeclaration;
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
« tool/input_sdk/private/js_mirrors.dart ('K') | « tool/input_sdk/private/js_mirrors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698