Issue 1186633003: Use drawable_xxhdpi instead of 2x_web

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1186633003: Use drawable_xxhdpi instead of 2x_web (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Use drawable_xxhdpi instead of 2x_web This makes the icons look nicer on the Nexus 5 I briefly played with trying to figure out which drawable_* to use dynamically, but I couldn't seem to write a reasonable solution which worked on both Desktop and my Nexus 5, leading me to believe I didn't understand how it should work and just went with xxhdpi for now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d0706ef2dc70c2223979b77197c9d032d178ea77

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	mojo/tools/deploy_domokit_site.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/sdk/lib/framework/widgets/icon.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 6 months ago (2015-06-12 20:50:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d0706ef2dc70c2223979b77197c9d032d178ea77 (presubmit successful).

Expand Messages | Collapse Messages