Set target platform on root node earlier.

Set target platform on root node earlier.

Fix to grd_reader.py proposed by thakis@chromium.org and used verbatim
from his proposal. I added the regression test to surface the problem
(prior to this fix) in a unit test on all platforms where one of the
is_xyz shortcuts in .grd expressions is true.

BUG=https://code.google.com/p/grit-i18n/issues/detail?id=23

Committed: https://code.google.com/p/grit-i18n/source/detail?r=141

[Jói, 2013-12-27 14:32:43]

Will land TBR so I can test this on the Chromium trybots.

Cheers,
Jói

[Jói, 2013-12-27 14:33:35]

Committed patchset #3 manually as r141 (presubmit successful).

[Nico, 2013-12-27 16:55:24]

lgtm, thank you!

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py
File grit/node/base.py (right):

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py#newcod...
grit/node/base.py:480: 'is_ios': platform_assertion == 'is_ios',
nit (optional, and since this is already landed best ignore): You could set them
all to 0 here and then do

  variable_map[platform_assertion] = 1

right after the dict definition is done

[Nico, 2014-01-28 20:48:35]

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py
File grit/node/base.py (right):

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py#newcod...
grit/node/base.py:483: or 'bsd' in sys.platform),
Hey, it looks like you dropped 'ios' and 'android' from is_posix in this change.
I guess that wasn't intentional?

[Jói, 2014-01-29 13:41:39]

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py
File grit/node/base.py (right):

https://codereview.chromium.org/118663003/diff/50001/grit/node/base.py#newcod...
grit/node/base.py:483: or 'bsd' in sys.platform),
On 2014/01/28 20:48:35, Nico wrote:
> Hey, it looks like you dropped 'ios' and 'android' from is_posix in this
change.
> I guess that wasn't intentional?

Whoops, that looks like a bad merge maybe. Not intentional, will fix.