Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1186623003: [SP] Turn off slimming paint by default. (Closed)

Created:
5 years, 6 months ago by wkorman
Modified:
5 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SP] Turn off slimming paint by default. Partial revert of http://crrev.com/1169193003 while we explore performance regressions. Leave the --disable-slimming-paint switch in existence, but restore prior logic around switches. BUG=497950, 501251 TBR=jochen Committed: https://crrev.com/3908f356c8af559adb6941adf4df77432b8275c2 Cr-Commit-Position: refs/heads/master@{#335386}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Merge changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
wkorman
5 years, 6 months ago (2015-06-12 20:16:24 UTC) #2
chrishtr
https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (left): https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc#oldcode472 content/browser/renderer_host/render_view_host_impl.cc:472: switches::kEnableSlimmingPaint) || switches::kDisableSlimmingPaint || !switches::kEnableSlimmingPaint
5 years, 6 months ago (2015-06-12 20:18:09 UTC) #3
wkorman
https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (left): https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc#oldcode472 content/browser/renderer_host/render_view_host_impl.cc:472: switches::kEnableSlimmingPaint) || On 2015/06/12 at 20:18:09, chrishtr wrote: > ...
5 years, 6 months ago (2015-06-12 20:20:17 UTC) #4
chrishtr
https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (left): https://codereview.chromium.org/1186623003/diff/1/content/browser/renderer_host/render_view_host_impl.cc#oldcode472 content/browser/renderer_host/render_view_host_impl.cc:472: switches::kEnableSlimmingPaint) || On 2015/06/12 at 20:20:17, wkorman wrote: > ...
5 years, 6 months ago (2015-06-12 20:24:24 UTC) #5
wkorman
Updated and resending in prep for potential application for perf undo/redo.
5 years, 6 months ago (2015-06-19 21:09:44 UTC) #7
chrishtr
lgtm
5 years, 6 months ago (2015-06-19 21:32:16 UTC) #9
wkorman
+jochen for OWNERS, submitting TBR as we're actively working with perf sheriffs on this.
5 years, 6 months ago (2015-06-19 21:35:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186623003/20001
5 years, 6 months ago (2015-06-19 21:36:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 23:11:41 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3908f356c8af559adb6941adf4df77432b8275c2 Cr-Commit-Position: refs/heads/master@{#335386}
5 years, 6 months ago (2015-06-19 23:13:08 UTC) #16
chrishtr
5 years, 6 months ago (2015-06-21 18:47:38 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1200693002/ by chrishtr@chromium.org.

The reason for reverting is: crbug.com/501015 made it hard to anaylyze the
regressions in crbug.com/501251. the issue causing crbug.com/501015 has been
reverted, so it's time to turn slimming paint back on..

Powered by Google App Engine
This is Rietveld 408576698