Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: Source/core/inspector/InspectorStyleSheet.cpp

Issue 1186613005: DevTools: migrate inspector's ParsedStyleSheet to Oilpan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: finalized Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorStyleSheet.cpp
diff --git a/Source/core/inspector/InspectorStyleSheet.cpp b/Source/core/inspector/InspectorStyleSheet.cpp
index e7683e2d62d1e48505e091203410a9f95d9080a5..8749811e940f9f1db628a6cbff938ac9c2476c5b 100644
--- a/Source/core/inspector/InspectorStyleSheet.cpp
+++ b/Source/core/inspector/InspectorStyleSheet.cpp
@@ -335,8 +335,7 @@ void StyleSheetHandler::endMediaQuery()
} // namespace
-class ParsedStyleSheet {
- WTF_MAKE_FAST_ALLOCATED(ParsedStyleSheet);
+class ParsedStyleSheet : public NoBaseWillBeGarbageCollectedFinalized<ParsedStyleSheet> {
public:
ParsedStyleSheet(CSSStyleSheet* pageStyleSheet);
@@ -348,14 +347,16 @@ public:
PassRefPtrWillBeRawPtr<blink::CSSRuleSourceData> ruleSourceDataAt(unsigned) const;
unsigned ruleCount() { return m_sourceData->size(); }
+ DECLARE_TRACE();
+
private:
void flattenSourceData(RuleSourceDataList*);
void setSourceData(PassOwnPtrWillBeRawPtr<RuleSourceDataList>);
String m_text;
bool m_hasText;
- OwnPtrWillBePersistent<RuleSourceDataList> m_sourceData;
- RefPtrWillBePersistent<CSSStyleSheet> m_pageStyleSheet;
+ OwnPtrWillBeMember<RuleSourceDataList> m_sourceData;
+ RefPtrWillBeMember<CSSStyleSheet> m_pageStyleSheet;
};
ParsedStyleSheet::ParsedStyleSheet(CSSStyleSheet* pageStyleSheet)
@@ -434,6 +435,12 @@ PassRefPtrWillBeRawPtr<blink::CSSRuleSourceData> ParsedStyleSheet::ruleSourceDat
return m_sourceData->at(index);
}
+DEFINE_TRACE(ParsedStyleSheet)
+{
+ visitor->trace(m_sourceData);
+ visitor->trace(m_pageStyleSheet);
+}
+
namespace blink {
enum MediaListSource {
@@ -953,6 +960,7 @@ DEFINE_TRACE(InspectorStyleSheet)
visitor->trace(m_cssAgent);
visitor->trace(m_resourceAgent);
visitor->trace(m_pageStyleSheet);
+ visitor->trace(m_parsedStyleSheet);
visitor->trace(m_flatRules);
InspectorStyleSheetBase::trace(visitor);
}
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698