Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(95)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1186613005: DevTools: migrate inspector's ParsedStyleSheet to Oilpan. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman, lushnikov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: migrate inspector's ParsedStyleSheet to Oilpan. R=dgozman,lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197129

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : lusha's comment addressed #

Patch Set 5 : finalized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/core/inspector/InspectorStyleSheet.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 4 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 10 months ago (2015-06-13 15:57:50 UTC) #1
yurys
lgtm https://codereview.chromium.org/1186613005/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (left): https://codereview.chromium.org/1186613005/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp#oldcode939 Source/core/inspector/InspectorStyleSheet.cpp:939: m_parsedStyleSheet = adoptPtr(new ParsedStyleSheet(m_pageStyleSheet.get())); Why was it removed? ...
4 years, 10 months ago (2015-06-15 08:21:56 UTC) #3
lushnikov
https://codereview.chromium.org/1186613005/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1186613005/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp#newcode1329 Source/core/inspector/InspectorStyleSheet.cpp:1329: m_flatRules.clear(); this is wrong - updateText is called from ...
4 years, 10 months ago (2015-06-15 12:21:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186613005/80001
4 years, 10 months ago (2015-06-15 16:11:23 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 17:37:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197129

Powered by Google App Engine
This is Rietveld 408576698