Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 11866012: Revert 176406 (Closed)

Created:
7 years, 11 months ago by ncarter (slow)
Modified:
7 years, 11 months ago
Reviewers:
mvrable
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 176406 > Do not pass URLs in onUpdated events to extensions unless they have the > "tabs" permission. > > BUG=168442 > > > Review URL: https://chromiumcodereview.appspot.com/11824004 TBR=mvrable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -133 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 6 chunks +17 lines, -27 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 2 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 4 chunks +18 lines, -25 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/browser/extensions/menu_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/tabs/no_permissions/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/tabs/no_permissions/test.js View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ncarter (slow)
7 years, 11 months ago (2013-01-11 20:20:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698