Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: DEPS

Issue 1186593003: Add a stale .pyc cleanup step before running gyp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more dirs Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index 8b63893f643c5247ce5a822394242bbf0d9120af..768a811af604969d78e305ca75af9d3bca3484f7 100644
--- a/DEPS
+++ b/DEPS
@@ -747,6 +747,22 @@ hooks = [
'action': ['python', 'src/third_party/instrumented_libraries/scripts/download_binaries.py'],
},
{
+ # Ensure that while generating dependencies lists in .gyp files we don't accidentally
scottmg 2015/06/12 22:58:25 nit; Wrap at 80 col since there's nothing preventi
mnaganov (inactive) 2015/06/12 23:26:17 Done.
+ # reference any .pyc files whose corresponding .py files have already been deleted.
+ 'name': 'remove_stale_pyc_files_for_gyp',
scottmg 2015/06/12 22:58:25 Probably just 'remove_stale_pyc_files' is better.
mnaganov (inactive) 2015/06/12 23:26:17 Done.
+ 'pattern': '.',
+ 'action': [
+ 'python',
+ 'src/tools/remove_stale_pyc_files.py',
+ 'src/android_webview/tools',
+ 'src/gpu/gles2_conform_support',
+ 'src/ppapi',
+ 'src/printing',
+ 'src/third_party/closure_compiler/build',
+ 'src/tools',
+ ],
scottmg 2015/06/12 22:58:25 I was worried this would be kind of slow, but on W
mnaganov (inactive) 2015/06/12 23:26:17 RemoveAllStalePycFiles doesn't skip output dirs, a
+ },
+ {
# A change to a .gyp, .gypi, or to GYP itself should run the generator.
'name': 'gyp',
'pattern': '.',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698