Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1186543002: Oilpan: fix build after r197039. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dshwang, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, blink-reviews-html_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r197039. CSSFontSelectorClient now needs to a GC mixin. TBR=oilpan-reviews BUG=481515 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M Source/core/css/CSSFontSelectorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DState.h View 3 chunks +14 lines, -3 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-12 16:06:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186543002/1
5 years, 6 months ago (2015-06-12 16:06:59 UTC) #3
haraken
LGTM
5 years, 6 months ago (2015-06-12 16:09:30 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 16:10:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197044

Powered by Google App Engine
This is Rietveld 408576698