Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1186523004: Rename adjustPaintInvalidationRect and related to addVisualOverflow (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
CC:
aboxhall, blink-reviews, blink-reviews-rendering, dmazzoni, eae+blinkwatch, jchaffraix+rendering, je_julie, leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename adjustPaintInvalidationRect and related to addVisualOverflow LayoutTheme::adjustPaintInvalidationRect is only used for adding visual overflow but that wasn't obvious from the name. This patch renames adjustPaintInvalidationRect and inflateControlPaintRect to addVisualOverflow. The parameter order of inflateControlPaintRect has also been changed so that the out param for the rect is last. BUG=498814 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTheme.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 3 chunks +15 lines, -15 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/Theme.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186523004/1
4 years, 10 months ago (2015-06-13 21:53:22 UTC) #3
pdr.
4 years, 10 months ago (2015-06-13 22:23:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-13 22:58:27 UTC) #6
chrishtr
lgtm
4 years, 10 months ago (2015-06-14 04:22:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186523004/1
4 years, 10 months ago (2015-06-14 04:22:22 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-14 04:25:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197094

Powered by Google App Engine
This is Rietveld 408576698