Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1186523002: Clean up unused AX APIs. (Closed)

Created:
5 years, 6 months ago by je_julie(Not used)
Modified:
5 years, 6 months ago
Reviewers:
dmazzoni, dglazkov
CC:
aboxhall, blink-reviews, dglazkov+blink, dmazzoni, je_julie, nektarios
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up unused AX APIs. Content was updated to use html attributes instead of using textInputType(),isAriaGrabbed() and ariaDropEffect() at https://codereview.chromium.org/1162263008/. This patch cleans them up. BUG=480861 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M Source/modules/accessibility/AXNodeObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 3 chunks +0 lines, -29 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebAXObject.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -9 lines 0 comments Download
M public/web/WebAXObject.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
je_julie(Not used)
Dominic, PTAL.
5 years, 6 months ago (2015-06-12 14:55:23 UTC) #2
dmazzoni
lgtm +dglazkov for public/web
5 years, 6 months ago (2015-06-12 15:48:48 UTC) #4
je_julie(Not used)
On 2015/06/12 15:48:48, dmazzoni wrote: > lgtm > > +dglazkov for public/web @dglazkov, PTAL.
5 years, 6 months ago (2015-06-17 05:50:15 UTC) #5
dglazkov
lgtm
5 years, 6 months ago (2015-06-17 16:21:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186523002/1
5 years, 6 months ago (2015-06-17 16:22:17 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 19:34:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197275

Powered by Google App Engine
This is Rietveld 408576698