Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 11865015: Move IPC tests into anonymous namespaces. (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move IPC tests into anonymous namespaces. This reduces chances of (very confusing) name collisions between different tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176430

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -105 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M ipc/ipc_perftests.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 2 37 chunks +19 lines, -94 lines 0 comments Download
M ipc/ipc_sync_message_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
Because if I'm going to do it for one file, I may as well do ...
7 years, 11 months ago (2013-01-11 19:15:11 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/11865015/diff/3001/ipc/ipc_message_utils_unittest.cc File ipc/ipc_message_utils_unittest.cc (right): https://codereview.chromium.org/11865015/diff/3001/ipc/ipc_message_utils_unittest.cc#newcode11 ipc/ipc_message_utils_unittest.cc:11: namespace { rather than this nesting I recommend ...
7 years, 11 months ago (2013-01-11 20:06:13 UTC) #2
viettrungluu
Thanks. On 2013/01/11 20:06:13, cpu wrote: > lgtm > > https://codereview.chromium.org/11865015/diff/3001/ipc/ipc_message_utils_unittest.cc > File ipc/ipc_message_utils_unittest.cc (right): ...
7 years, 11 months ago (2013-01-11 20:09:58 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 20:11:56 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698