Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 11865013: Merge 139346 (Closed)

Created:
7 years, 11 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139346 > ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views > https://bugs.webkit.org/show_bug.cgi?id=106383 > > Reviewed by James Robinson. > > Source/WebCore: > > ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit > testing rect. The rect this returns is in the coordinates of its document. This change converts the > rect to the outermost view's coordinate system using convertToContainingView. > > Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html > > * page/scrolling/ScrollingCoordinator.cpp: > (WebCore::accumulateRendererTouchEventTargetRects): > > LayoutTests: > > * platform/chromium/fast/events/touch/resources: Added. > * platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added. > * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added. > * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added. > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A + LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
7 years, 11 months ago (2013-01-11 18:57:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698