Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 11865005: Remove Futures class, move methods to Future. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1649 matching lines...) Expand 10 before | Expand all | Expand 10 after
1660 }; 1660 };
1661 } 1661 }
1662 1662
1663 Future _terminateBatchRunners() { 1663 Future _terminateBatchRunners() {
1664 var futures = new List(); 1664 var futures = new List();
1665 for (var runners in _batchProcesses.values) { 1665 for (var runners in _batchProcesses.values) {
1666 for (var runner in runners) { 1666 for (var runner in runners) {
1667 futures.add(runner.terminate()); 1667 futures.add(runner.terminate());
1668 } 1668 }
1669 } 1669 }
1670 // Change to Future.wait when updating binaries.
1670 return Futures.wait(futures); 1671 return Futures.wait(futures);
1671 } 1672 }
1672 1673
1673 BatchRunnerProcess _getBatchRunner(TestCase test) { 1674 BatchRunnerProcess _getBatchRunner(TestCase test) {
1674 // Start batch processes if needed 1675 // Start batch processes if needed
1675 var compiler = test.configuration['compiler']; 1676 var compiler = test.configuration['compiler'];
1676 var runners = _batchProcesses[compiler]; 1677 var runners = _batchProcesses[compiler];
1677 if (runners == null) { 1678 if (runners == null) {
1678 runners = new List<BatchRunnerProcess>(_maxProcesses); 1679 runners = new List<BatchRunnerProcess>(_maxProcesses);
1679 for (int i = 0; i < _maxProcesses; i++) { 1680 for (int i = 0; i < _maxProcesses; i++) {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
1741 // the developer doesn't waste his or her time trying to fix a bunch of 1742 // the developer doesn't waste his or her time trying to fix a bunch of
1742 // tests that appear to be broken but were actually just flakes that 1743 // tests that appear to be broken but were actually just flakes that
1743 // didn't get retried because there had already been one failure. 1744 // didn't get retried because there had already been one failure.
1744 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1745 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1745 new RunningProcess(test, allowRetry, this).start(); 1746 new RunningProcess(test, allowRetry, this).start();
1746 } 1747 }
1747 _numProcesses++; 1748 _numProcesses++;
1748 } 1749 }
1749 } 1750 }
1750 } 1751 }
OLDNEW
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698