Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1186473004: Move <link rel=preconnect> crossorigin logic to the blink side (Closed)

Created:
5 years, 6 months ago by Yoav Weiss
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move <link rel=preconnect> crossorigin logic to the blink side Following comments on https://codereview.chromium.org/1131293004/ this CL moves the cross origin logic of <link rel=preconnect> to the blink side. BUG=468005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197035

Patch Set 1 #

Patch Set 2 : Build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M Source/core/html/CrossOriginAttribute.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/CrossOriginAttributeValue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/network/NetworkHints.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/NetworkHints.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D public/platform/WebCrossOriginAttribute.h View 1 chunk +0 lines, -19 lines 0 comments Download
M public/platform/WebPrescientNetworking.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoav Weiss
Hey Mike, Following Ryan's comments on https://codereview.chromium.org/1131293004/ I've moved the cross origin logic to the ...
5 years, 6 months ago (2015-06-12 09:15:27 UTC) #2
Mike West
LGTM.
5 years, 6 months ago (2015-06-12 12:29:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186473004/20001
5 years, 6 months ago (2015-06-12 12:30:42 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 13:22:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197035

Powered by Google App Engine
This is Rietveld 408576698