Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 1186453002: Oilpan profiling: Trace GC heuristic parameters. (Closed)

Created:
4 years, 10 months ago by Yuta Kitamura
Modified:
4 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan profiling: Trace GC heuristic parameters. This patch adds tracing of a few metrics used by Oilpan to determine whether it should schedule a GC. With a GC tracing-enabled build, you can see how these values change over time from about:tracing. BUG=none R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
Yuta Kitamura
4 years, 10 months ago (2015-06-12 06:05:04 UTC) #1
haraken
LGTM
4 years, 10 months ago (2015-06-12 06:06:14 UTC) #2
keishi
LGTM. I will add these to JS.
4 years, 10 months ago (2015-06-12 06:06:56 UTC) #3
keishi
On 2015/06/12 06:06:56, keishi wrote: > LGTM. I will add these to JS. I see. ...
4 years, 10 months ago (2015-06-12 06:10:00 UTC) #4
Yuta Kitamura
On 2015/06/12 06:10:00, keishi wrote: > On 2015/06/12 06:06:56, keishi wrote: > > LGTM. I ...
4 years, 10 months ago (2015-06-12 06:26:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186453002/1
4 years, 10 months ago (2015-06-12 06:27:01 UTC) #7
keishi
On 2015/06/12 06:26:05, Yuta Kitamura wrote: > On 2015/06/12 06:10:00, keishi wrote: > > On ...
4 years, 10 months ago (2015-06-12 06:27:33 UTC) #8
Yuta Kitamura
On 2015/06/12 06:27:33, keishi wrote: > No problem. Do you have a sample JSON file ...
4 years, 10 months ago (2015-06-12 06:29:39 UTC) #9
Yuta Kitamura
On 2015/06/12 06:29:39, Yuta Kitamura wrote: > On 2015/06/12 06:27:33, keishi wrote: > > No ...
4 years, 10 months ago (2015-06-12 06:33:12 UTC) #10
keishi
On 2015/06/12 06:33:12, Yuta Kitamura wrote: > On 2015/06/12 06:29:39, Yuta Kitamura wrote: > > ...
4 years, 10 months ago (2015-06-12 07:06:17 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 07:48:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197014

Powered by Google App Engine
This is Rietveld 408576698