Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1186443002: Revert of [Android] Make adb_install_apk use the device blacklist. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Make adb_install_apk use the device blacklist. (patchset #1 id:1 of https://codereview.chromium.org/1182623002/) Reason for revert: broke at least chromium.gpu: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/21362 Original issue's description: > [Android] Make adb_install_apk use the device blacklist. > > BUG=498232 > > Committed: https://crrev.com/7197964049d0db49c02421859b6dafc7bfdc516e > Cr-Commit-Position: refs/heads/master@{#334073} TBR=navabi@chromium.org,mikecase@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498232 Committed: https://crrev.com/9d5368439e8115ee9ff055917b684f5b9badafcc Cr-Commit-Position: refs/heads/master@{#334123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -60 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +57 lines, -60 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Make adb_install_apk use the device blacklist.
5 years, 6 months ago (2015-06-12 03:52:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186443002/1
5 years, 6 months ago (2015-06-12 03:52:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 03:53:04 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 03:54:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d5368439e8115ee9ff055917b684f5b9badafcc
Cr-Commit-Position: refs/heads/master@{#334123}

Powered by Google App Engine
This is Rietveld 408576698