Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 11864024: Merge 139435 (Closed)

Created:
7 years, 11 months ago by kerz_chromium
Modified:
7 years, 11 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139435 > Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately. > https://bugs.webkit.org/show_bug.cgi?id=105188 > > Patch by Anton Vayvod <avayvod@chromium.org>; on 2013-01-11 > Reviewed by Kenneth Rohde Christiansen. > > Source/WebCore: > > Some blocks of text might be narrower than their parent clusters and should be autosized separately. > This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and > the main content being positioned atop this margin (or vice versa). > > * rendering/TextAutosizer.cpp: > (WebCore::TextAutosizer::isContainerAutosizingCluster): > > Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common > ancestor of all the text nodes. > > LayoutTests: > > Checked that a narrow autosizing container becomes an autosizing cluster. > Fixed other tests that used narrow descendant blocks. > > * fast/text-autosizing/cluster-narrow-in-wide-expected.html: > * fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html: > * fast/text-autosizing/cluster-narrow-in-wide-ohidden.html: > * fast/text-autosizing/cluster-narrow-in-wide.html: > * fast/text-autosizing/cluster-with-wide-lca-expected.html: > * fast/text-autosizing/cluster-with-wide-lca.html: > * fast/text-autosizing/narrow-child-expected.html: > * fast/text-autosizing/narrow-child.html: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139474

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 11 months ago (2013-01-11 19:43:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698