Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 11864010: Improve checking of patches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased (again) Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/sdk/lib/_internal/compiler/implementation/warnings.dart b/sdk/lib/_internal/compiler/implementation/warnings.dart
index 343ad14d991d4941cc281ec93ccd8fff84f01fb8..5494effd66e9a41006822d4112069977c3ad72d2 100644
--- a/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -360,31 +360,6 @@ Invalid offset (#{offset}) in source map.
File: #{fileName}
Length: #{length}''');
- static const PATCH_RETURN_TYPE_MISMATCH = const MessageKind(
- "Patch return type '#{patchReturnType}' doesn't match "
- "'#{originReturnType}' on origin method '#{methodName}'.");
-
- static const PATCH_REQUIRED_PARAMETER_COUNT_MISMATCH = const MessageKind(
- "Required parameter count of patch method (#{patchParameterCount}) "
- "doesn't match parameter count on origin method '#{methodName}' "
- "(#{originParameterCount}).");
-
- static const PATCH_OPTIONAL_PARAMETER_COUNT_MISMATCH = const MessageKind(
- "Optional parameter count of patch method (#{patchParameterCount}) "
- "doesn't match parameter count on origin method '#{methodName}' "
- "(#{originParameterCount}).");
-
- static const PATCH_OPTIONAL_PARAMETER_NAMED_MISMATCH = const MessageKind(
- "Optional parameters of origin and patch method '#{methodName}' must "
- "both be either named or positional.");
-
- static const PATCH_PARAMETER_MISMATCH = const MessageKind(
- "Patch method parameter '#{patchParameter}' doesn't match "
- "'#{originParameter}' on origin method #{methodName}.");
-
- static const EXTERNAL_WITHOUT_IMPLEMENTATION = const MessageKind(
- "External method without an implementation.");
-
static const TOP_LEVEL_VARIABLE_DECLARED_STATIC = const MessageKind(
"Top-level variable cannot be declared static.");
@@ -424,6 +399,87 @@ Please include the following information:
below as well as the source location above).
''');
+
+ //////////////////////////////////////////////////////////////////////////////
+ // Patch errors start.
+ //////////////////////////////////////////////////////////////////////////////
+
+ static const PATCH_RETURN_TYPE_MISMATCH = const MessageKind(
+ "Patch return type '#{patchReturnType}' doesn't match "
+ "'#{originReturnType}' on origin method '#{methodName}'.");
+
+ static const PATCH_REQUIRED_PARAMETER_COUNT_MISMATCH = const MessageKind(
+ "Required parameter count of patch method (#{patchParameterCount}) "
+ "doesn't match parameter count on origin method '#{methodName}' "
+ "(#{originParameterCount}).");
+
+ static const PATCH_OPTIONAL_PARAMETER_COUNT_MISMATCH = const MessageKind(
+ "Optional parameter count of patch method (#{patchParameterCount}) "
+ "doesn't match parameter count on origin method '#{methodName}' "
+ "(#{originParameterCount}).");
+
+ static const PATCH_OPTIONAL_PARAMETER_NAMED_MISMATCH = const MessageKind(
+ "Optional parameters of origin and patch method '#{methodName}' must "
+ "both be either named or positional.");
+
+ static const PATCH_PARAMETER_MISMATCH = const MessageKind(
+ "Patch method parameter '#{patchParameter}' doesn't match "
+ "'#{originParameter}' on origin method #{methodName}.");
+
+ static const PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION = const MessageKind(
+ "External method without an implementation.");
+
+ static const PATCH_POINT_TO_FUNCTION = const MessageKind(
+ "Info: This is the function patch '#{functionName}'.");
+
+ static const PATCH_POINT_TO_CLASS = const MessageKind(
+ "Info: This is the class patch '#{className}'.");
+
+ static const PATCH_POINT_TO_GETTER = const MessageKind(
+ "Info: This is the getter patch '#{getterName}'.");
+
+ static const PATCH_POINT_TO_SETTER = const MessageKind(
+ "Info: This is the setter patch '#{setterName}'.");
+
+ static const PATCH_POINT_TO_CONSTRUCTOR = const MessageKind(
+ "Info: This is the constructor patch '#{constructorName}'.");
+
+ static const PATCH_NON_EXISTING = const MessageKind(
+ "Error: Origin does not exist for patch '#{name}'.");
+
+ static const PATCH_NONPATCHABLE = const MessageKind(
+ "Error: Only classes and functions can be patched.");
+
+ static const PATCH_NON_EXTERNAL = const MessageKind(
+ "Error: Only external functions can be patched.");
+
+ static const PATCH_NON_CLASS = const MessageKind(
+ "Error: Patching non-class with class patch '#{className}'.");
+
+ static const PATCH_NON_GETTER = const MessageKind(
+ "Error: Cannot patch non-getter '#{name}' with getter patch.");
+
+ static const PATCH_NO_GETTER = const MessageKind(
+ "Error: No getter found for getter patch '#{getterName}'.");
+
+ static const PATCH_NON_SETTER = const MessageKind(
+ "Error: Cannot patch non-setter '#{name}' with setter patch.");
+
+ static const PATCH_NO_SETTER = const MessageKind(
+ "Error: No setter found for setter patch '#{setterName}'.");
+
+ static const PATCH_NON_CONSTRUCTOR = const MessageKind(
+ "Error: Cannot patch non-constructor with constructor patch "
+ "'#{constructorName}'.");
+
+ static const PATCH_NON_FUNCTION = const MessageKind(
+ "Error: Cannot patch non-function with function patch "
+ "'#{functionName}'.");
+
+ //////////////////////////////////////////////////////////////////////////////
+ // Patch errors end.
+ //////////////////////////////////////////////////////////////////////////////
+
toString() => template;
Message message([Map arguments = const {}]) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | tests/compiler/dart2js/patch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698