src/trusted/validator/x86/64/ncvalidate.c - Issue 11864002: Move CPU features into its own static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/64/ncvalidate.c

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator/x86/64/ncvalidate.c

diff --git a/src/trusted/validator/x86/64/ncvalidate.c b/src/trusted/validator/x86/64/ncvalidate.c

index db0193f9478d10b359f51ffe83cbe692189e4a81..9a41e4c2b73f4ee3b4f0f60ac64f662fadfee9dd 100644

--- a/src/trusted/validator/x86/64/ncvalidate.c

+++ b/src/trusted/validator/x86/64/ncvalidate.c

@@ -11,7 +11,7 @@

#include "native_client/src/trusted/validator/validation_cache.h"

#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter.h"

#include "native_client/src/trusted/validator/x86/decoder/nc_inst_state_internal.h"

-#include "native_client/src/trusted/validator/x86/nacl_cpuid.h"

+#include "native_client/src/trusted/cpu_features/arch/x86/cpu_x86.h"

#include "native_client/src/trusted/validator/x86/nc_segment.h"

#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncval_decode_tables.h"

#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"