src/trusted/validator/ncvalidate.h - Issue 11864002: Move CPU features into its own static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/ncvalidate.h

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator/ncvalidate.h

diff --git a/src/trusted/validator/ncvalidate.h b/src/trusted/validator/ncvalidate.h

index 040232612afe520555c65a101152ef16677c9029..164afd4313b2e01fc35ef47408476bb68863cee8 100644

--- a/src/trusted/validator/ncvalidate.h

+++ b/src/trusted/validator/ncvalidate.h

@@ -11,19 +11,13 @@

#include "native_client/src/include/nacl_base.h"

#include "native_client/src/include/portability.h"

+#include "native_client/src/trusted/cpu_features/cpu_features.h"

EXTERN_C_BEGIN

struct NaClValidationCache;

-/*

- * Forward-declared (but never defined) generic CPU features.

- * Each architecture needs to cast from this generic type.

- */

-struct NaClCPUFeaturesAbstract;

-typedef struct NaClCPUFeaturesAbstract NaClCPUFeatures;

/* Defines possible validation status values. */

typedef enum NaClValidationStatus {

/* The call to the validator succeeded. */