Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/trusted/platform_qualify/build.scons

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/platform_qualify/arch/x86/vcpuid.c ('k') | src/trusted/platform_qualify/platform_qualify.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/platform_qualify/build.scons
diff --git a/src/trusted/platform_qualify/build.scons b/src/trusted/platform_qualify/build.scons
index 668f4e4b0b9de01454b9111dbe6897d1e66b45c8..f11f527b068c165874299b3e10f2355551b2b644 100644
--- a/src/trusted/platform_qualify/build.scons
+++ b/src/trusted/platform_qualify/build.scons
@@ -11,6 +11,7 @@ Import('env')
pql_inputs = []
+extra_libs = []
#
# OS-specific qualification routines
@@ -44,11 +45,12 @@ if env.Bit('build_x86') and env.Bit('target_x86'):
vcpuid_env.FilterOut(CCFLAGS = ['-fPIC'])
if env.Bit('linux'):
vcpuid_env.Append(CCFLAGS = ['-msse3'])
- env.Prepend(LIBS = ['platform_qual_lib',
- TargetLib(env, 'ncval_base'),
- 'platform', 'gio'])
nacl_vcpuid = vcpuid_env.ComponentLibrary('vcpuid', 'arch/x86/vcpuid.c')
- env.Append(LIBS = ['vcpuid'])
+ extra_libs += ['platform_qual_lib',
+ TargetLib(env, 'ncval_base'),
+ 'platform',
+ 'gio',
+ 'vcpuid']
if env.Bit('target_x86_64'):
# Compile x86-64 primitives for verifying NX functionality
@@ -59,14 +61,15 @@ if env.Bit('build_x86') and env.Bit('target_x86'):
platform_qual_test = env.ComponentProgram(
'platform_qual_test', 'arch/x86/platform_qual_test.c',
# 'sel' is required for sel_memory.c and friends
- EXTRA_LIBS=['platform_qual_lib', 'sel'])
+ EXTRA_LIBS=extra_libs + ['sel'])
node = env.CommandTest('platform_qual_test.out', [platform_qual_test])
env.AddNodeToTestSuite(
node, ['small_tests'], 'run_platform_qual_test',
is_broken=env.IsRunningUnderValgrind())
cpuwhitelist_test = env.ComponentProgram(
- 'cpuwhitelist_test', 'arch/x86/nacl_cpuwhitelist_test.c')
+ 'cpuwhitelist_test', 'arch/x86/nacl_cpuwhitelist_test.c',
+ EXTRA_LIBS=extra_libs)
node = env.CommandTest('cpuwhitelist_test.out', [cpuwhitelist_test])
env.AddNodeToTestSuite(node, ['small_tests'], 'run_cpuwhitelist_test')
« no previous file with comments | « src/trusted/platform_qualify/arch/x86/vcpuid.c ('k') | src/trusted/platform_qualify/platform_qualify.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698