Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: src/trusted/cpu_features/cpu_features.gyp

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/cpu_features/cpu_features.h ('k') | src/trusted/platform_qualify/arch/x86/nacl_cpuwhitelist.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/cpu_features/cpu_features.gyp
diff --git a/src/trusted/validator_arm/validator_arm.gyp b/src/trusted/cpu_features/cpu_features.gyp
similarity index 50%
copy from src/trusted/validator_arm/validator_arm.gyp
copy to src/trusted/cpu_features/cpu_features.gyp
index 90ceda5c868b7cc5c04dfef425609013a918998a..194bcf1baa492824d3894110c096d1e994635d88 100644
--- a/src/trusted/validator_arm/validator_arm.gyp
+++ b/src/trusted/cpu_features/cpu_features.gyp
@@ -1,5 +1,4 @@
-# Copyright 2010, Google Inc.
-# Copyright 2009 The Native Client Authors. All rights reserved.
+# Copyright 2013 The Native Client Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can
# be found in the LICENSE file.
@@ -37,34 +36,51 @@
'targets': [
# ----------------------------------------------------------------------
{
- 'target_name': 'arm_validator_core',
+ 'target_name': 'cpu_features',
'type': 'static_library',
- 'sources': [
- 'address_set.cc',
- 'actual_classes.cc',
- 'baseline_classes.cc',
- 'cpuid_arm.c',
- 'inst_classes.cc',
- 'model.cc',
- 'validator.cc',
- 'gen/arm32_decode.cc',
- 'gen/arm32_decode_actuals.cc'
+ # TODO(jfb) See TODO in build.scons on why x86 is built this way.
+ 'conditions': [
+ ['target_arch=="ia32" or target_arch=="x64"', {
+ 'sources': [
+ 'arch/arm/cpu_arm.c',
+ 'arch/mips/cpu_mips.c',
+ 'arch/x86/cpu_x86.c',
+ 'arch/x86/cpu_xgetbv.S',
+ ],
+ }],
+ ['target_arch=="arm" or target_arch=="mips"', {
+ 'sources': [
+ 'arch/arm/cpu_arm.c',
+ 'arch/mips/cpu_mips.c',
+ ],
+ }],
],
- },
- # ----------------------------------------------------------------------
- {
- 'target_name': 'ncvalidate_arm_v2',
- 'type': 'static_library',
- 'sources': [ 'ncvalidate.cc' ],
'dependencies': [
- 'arm_validator_core'
+ '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
],
},
- # ----------------------------------------------------------------------
- {
- 'target_name': 'arm_validator_reporters',
- 'type': 'static_library',
- 'sources': [ 'problem_reporter.cc' ],
+ ],
+ 'conditions': [
+ ['OS=="win" and target_arch=="ia32"', {
+ 'targets': [
+ {
+ 'target_name': 'cpu_features64',
+ 'type': 'static_library',
+ 'variables': {
+ 'win_target': 'x64',
+ },
+ 'sources': [
+ 'arch/arm/cpu_arm.c',
+ 'arch/mips/cpu_mips.c',
+ 'arch/x86/cpu_x86.c',
+ 'arch/x86/cpu_xgetbv.S',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform64',
+ ],
+ },
+ ],
},
+ ],
],
}
« no previous file with comments | « src/trusted/cpu_features/cpu_features.h ('k') | src/trusted/platform_qualify/arch/x86/nacl_cpuwhitelist.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698