Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: src/trusted/validator/x86/nacl_xgetbv.S

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/nacl_xgetbv.S
diff --git a/src/trusted/validator/x86/nacl_xgetbv.S b/src/trusted/validator/x86/nacl_xgetbv.S
deleted file mode 100644
index 4c861fcb4ffafbc896e1c0b28397cb7e9fd9a0c1..0000000000000000000000000000000000000000
--- a/src/trusted/validator/x86/nacl_xgetbv.S
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2012 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-/*
- * This exists only because Windows 64 doesn't support trivial inline assembly.
- * Visual Studio 2010 SP1 has an intrinsic _xgetbv() for this.
- * But earlier versions do not.
- */
-
-#include "native_client/src/trusted/service_runtime/nacl_config.h"
-
- .text
-
-DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaClXGETBV):
-#if NACL_BUILD_SUBARCH == 32
- movl 4(%esp), %ecx
-#elif !NACL_WINDOWS
- movl %edi, %ecx
-#endif
- /*
- * This is "xgetbv" (no operands). Some assemblers don't know it yet.
- */
- .byte 0x0f, 0x01, 0xd0
-#if NACL_BUILD_SUBARCH == 64
- shlq $32, %rdx
- orq %rdx, %rax
-#endif
- ret
« no previous file with comments | « src/trusted/validator/x86/nacl_cpuid_test.c ('k') | src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698