src/trusted/cpu_features/arch/x86/cpu_xgetbv.S - Issue 11864002: Move CPU features into its own static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/cpu_features/arch/x86/cpu_xgetbv.S

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Another go at Windows x64, with help from Noel. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/cpu_features/arch/x86/cpu_xgetbv.S

diff --git a/src/trusted/validator/x86/nacl_xgetbv.S b/src/trusted/cpu_features/arch/x86/cpu_xgetbv.S

similarity index 94%

rename from src/trusted/validator/x86/nacl_xgetbv.S

rename to src/trusted/cpu_features/arch/x86/cpu_xgetbv.S

index 4c861fcb4ffafbc896e1c0b28397cb7e9fd9a0c1..39207eafd8cebce118ed8c159976d75fef97fa6f 100644

--- a/src/trusted/validator/x86/nacl_xgetbv.S

+++ b/src/trusted/cpu_features/arch/x86/cpu_xgetbv.S

@@ -15,6 +15,7 @@

.text

DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaClXGETBV):

+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_x86

#if NACL_BUILD_SUBARCH == 32

movl 4(%esp), %ecx

#elif !NACL_WINDOWS

@@ -29,3 +30,4 @@ DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaClXGETBV):

orq %rdx, %rax

#endif

ret

+#endif

bsy 2013/01/11 21:11:30 isn't this a tad dangerous -- if this is not NACL_

Roland McGrath 2013/01/11 21:15:00 In other cases we just put #error in an #else clau

bsy 2013/01/11 21:19:53 the problem is that this is getting built for all