Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: src/trusted/platform_qualify/platform_qualify.gyp

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # -*- python -*-
2 # Copyright (c) 2012 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 3 # found in the LICENSE file.
5 4
6 { 5 {
7 'variables': { 6 'variables': {
8 }, 7 },
9 'includes': [ 8 'includes': [
10 '../../../build/common.gypi', 9 '../../../build/common.gypi',
11 ], 10 ],
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 }], 70 }],
72 ], 71 ],
73 }, 72 },
74 'targets': [ 73 'targets': [
75 { 74 {
76 'target_name': 'platform_qual_lib', 75 'target_name': 'platform_qual_lib',
77 'type': 'static_library', 76 'type': 'static_library',
78 'variables': { 77 'variables': {
79 'target_base': 'pqlib', 78 'target_base': 'pqlib',
80 }, 79 },
81 # For nacl_cpuid used by nacl_cpuwhitelist. 80 'dependencies': [
82 'conditions': [ 81 '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cpu_fe atures',
83 ['target_arch=="ia32"', {
84 'dependencies': [
85 '<(DEPTH)/native_client/src/trusted/validator/x86/validate_x86.gyp:ncv al_base_x86_32',
86 ],
87 }],
88 ['target_arch=="x64"', {
89 'dependencies': [
90 '<(DEPTH)/native_client/src/trusted/validator/x86/validate_x86.gyp:ncv al_base_x86_64',
91 ],
92 }],
93 ], 82 ],
94 }, 83 },
95 ], 84 ],
96 'conditions': [ 85 'conditions': [
97 ['OS=="win"', { 86 ['OS=="win"', {
98 'targets': [ 87 'targets': [
99 { 88 {
100 'target_name': 'platform_qual_lib64', 89 'target_name': 'platform_qual_lib64',
101 'type': 'static_library', 90 'type': 'static_library',
102 'variables': { 91 'variables': {
103 'target_base': 'pqlib', 92 'target_base': 'pqlib',
104 'win_target': 'x64', 93 'win_target': 'x64',
105 }, 94 },
106 'dependencies': [ 95 'dependencies': [
107 # For nacl_cpuid used by nacl_cpuwhitelist. 96 '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cp u_features64',
108 '<(DEPTH)/native_client/src/trusted/validator/x86/validate_x86.gyp:n cval_base_x86_64',
109 ], 97 ],
110 }, 98 },
111 ], 99 ],
112 }], 100 }],
113 ], 101 ],
114 } 102 }
115 103
116 # TODO: 104 # TODO:
117 # # Currently, this is only defined for x86, so only compile if x86. 105 # # Currently, this is only defined for x86, so only compile if x86.
118 # if env['TARGET_ARCHITECTURE'] != 'x86': 106 # if env['TARGET_ARCHITECTURE'] != 'x86':
119 # Return() 107 # Return()
120 #vcpuid_env = env.Clone() 108 #vcpuid_env = env.Clone()
121 #if env.Bit('mac'): 109 #if env.Bit('mac'):
122 # vcpuid_env.Append(CCFLAGS = ['-mdynamic-no-pic']) 110 # vcpuid_env.Append(CCFLAGS = ['-mdynamic-no-pic'])
123 #if env.Bit('linux'): 111 #if env.Bit('linux'):
124 # vcpuid_env.Append(CCFLAGS = ['-msse3']) 112 # vcpuid_env.Append(CCFLAGS = ['-msse3'])
125 #nacl_vcpuid = vcpuid_env.ComponentLibrary('vcpuid', 'vcpuid.c') 113 #nacl_vcpuid = vcpuid_env.ComponentLibrary('vcpuid', 'vcpuid.c')
126 #env.Append(LIBS = ['vcpuid', 'platform_qual_lib', 'ncvalidate']) 114 #env.Append(LIBS = ['vcpuid', 'platform_qual_lib', 'ncvalidate'])
127 # 115 #
128 #env.ComponentProgram('platform_qual_test', 'platform_qual_test.c') 116 #env.ComponentProgram('platform_qual_test', 'platform_qual_test.c')
129 #env.ComponentProgram('nacl_cpuwhitelist_test', 'nacl_cpuwhitelist_test.c') 117 #env.ComponentProgram('nacl_cpuwhitelist_test', 'nacl_cpuwhitelist_test.c')
130 # 118 #
OLDNEW
« no previous file with comments | « src/trusted/platform_qualify/build.scons ('k') | src/trusted/service_runtime/arch/x86_32/nacl_switch_to_app_32.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698