tools/release/test_scripts.py - Issue 1186393007: [release-tools] Fix possible race condition in retrieval of latest rolled version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/test_scripts.py

Issue 1186393007: [release-tools] Fix possible race condition in retrieval of latest rolled version (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed nit Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/release/test_scripts.py

diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py

index 32d0fb837c85f502add80c8c20ab65d6c4bd1c5f..da4f2d10fc894205c8a82adf0f924dc67184462e 100644

--- a/tools/release/test_scripts.py

+++ b/tools/release/test_scripts.py

@@ -1112,6 +1112,7 @@ deps = {

Cmd("git describe --tags bad_tag", ""),

Cmd("git describe --tags hash_234", "3.22.4"),

Cmd("git describe --tags hash_123", "3.22.3"),

+ Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),

Cmd("git describe --tags abcd123455", "3.22.4"),

Cmd("git describe --tags hash_234", "3.22.4"),

Cmd("git describe --tags hash_123", "3.22.3"),

@@ -1135,6 +1136,7 @@ deps = {

Cmd("git describe --tags bad_tag", ""),

Cmd("git describe --tags hash_234", "3.22.4"),

Cmd("git describe --tags hash_123", "3.22.3"),

+ Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),

Cmd("git describe --tags abcd123455", "3.22.3.1"),

Cmd("git describe --tags hash_234", "3.22.4"),

])

« no previous file with comments | « tools/release/auto_roll.py ('k') | no next file » | no next file with comments »