tools/release/auto_roll.py - Issue 1186393007: [release-tools] Fix possible race condition in retrieval of latest rolled version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/auto_roll.py

Issue 1186393007: [release-tools] Fix possible race condition in retrieval of latest rolled version (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/release/auto_roll.py

diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py

index f7692cf6f9775681a9afdb6c13d82c60bb874044..72fdbc55dd8753f8a8ef254ab825ce9346a0a0a8 100755

--- a/tools/release/auto_roll.py

+++ b/tools/release/auto_roll.py

@@ -48,6 +48,10 @@ class DetectLastRoll(Step):

max_age=self._options.max_age * DAY_IN_SECONDS)

assert revisions, "Didn't find any recent release."

+ # Update Chromium checkout before DEPS check to fix possible race-condition

+ cwd = self._options.chromium

+ self.GitPull(cwd=cwd)

Michael Achenbach 2015/06/18 19:41:27 nit: maybe inline cwd as it's single use and doesn

# Interpret the DEPS file to retrieve the v8 revision.

# TODO(machenbach): This should be part or the roll-deps api of

# depot_tools.

« no previous file with comments | « no previous file | tools/release/test_scripts.py » ('j') | no next file with comments »