Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1186393007: [release-tools] Fix possible race condition in retrieval of latest rolled version (Closed)

Created:
5 years, 6 months ago by Michael Hablich
Modified:
5 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release-tools] Fix possible race condition in retrieval of latest rolled version R=machenbach@chromium.org BUG= NOTRY=true Committed: https://crrev.com/5d2a85b2450f9f88a94949052c5b055c1304b9b8 Cr-Commit-Position: refs/heads/master@{#29137}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/release/auto_roll.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/release/test_scripts.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Hablich
5 years, 6 months ago (2015-06-18 14:28:22 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1186393007/diff/1/tools/release/auto_roll.py File tools/release/auto_roll.py (right): https://codereview.chromium.org/1186393007/diff/1/tools/release/auto_roll.py#newcode53 tools/release/auto_roll.py:53: self.GitPull(cwd=cwd) nit: maybe inline cwd as it's single ...
5 years, 6 months ago (2015-06-18 19:41:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393007/20001
5 years, 6 months ago (2015-06-19 09:10:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 09:11:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5d2a85b2450f9f88a94949052c5b055c1304b9b8 Cr-Commit-Position: refs/heads/master@{#29137}
5 years, 6 months ago (2015-06-19 09:12:13 UTC) #7
Michael Hablich
5 years, 6 months ago (2015-06-19 09:32:17 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1195693003/ by hablich@chromium.org.

The reason for reverting is: Build slave fetches git repo from cache not from
real repo..

Powered by Google App Engine
This is Rietveld 408576698