Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3017)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1186393004: gpu: Remove async texture uploads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/test_gles2_interface.cc ('k') | cc/trees/layer_tree_host_pixeltest_blending.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 5a1d2c6c2ad0729cf57047831b3de6fb89a31bfc..543d5f896d43b23325cdf603f26f17d70eb4ba69 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -58,7 +58,6 @@
#include "cc/raster/gpu_rasterizer.h"
#include "cc/raster/gpu_tile_task_worker_pool.h"
#include "cc/raster/one_copy_tile_task_worker_pool.h"
-#include "cc/raster/pixel_buffer_tile_task_worker_pool.h"
#include "cc/raster/tile_task_worker_pool.h"
#include "cc/raster/zero_copy_tile_task_worker_pool.h"
#include "cc/resources/memory_history.h"
@@ -130,29 +129,6 @@ void DidVisibilityChange(LayerTreeHostImpl* id, bool visible) {
TRACE_EVENT_ASYNC_END0("cc", "LayerTreeHostImpl::SetVisible", id);
}
-size_t GetMaxTransferBufferUsageBytes(
- const ContextProvider::Capabilities& context_capabilities,
- double refresh_rate) {
- // We want to make sure the default transfer buffer size is equal to the
- // amount of data that can be uploaded by the compositor to avoid stalling
- // the pipeline.
- // For reference Chromebook Pixel can upload 1MB in about 0.5ms.
- const size_t kMaxBytesUploadedPerMs = 1024 * 1024 * 2;
-
- // We need to upload at least enough work to keep the GPU process busy until
- // the next time it can handle a request to start more uploads from the
- // compositor. We assume that it will pick up any sent upload requests within
- // the time of a vsync, since the browser will want to swap a frame within
- // that time interval, and then uploads should have a chance to be processed.
- size_t ms_per_frame = std::floor(1000.0 / refresh_rate);
- size_t max_transfer_buffer_usage_bytes =
- ms_per_frame * kMaxBytesUploadedPerMs;
-
- // The context may request a lower limit based on the device capabilities.
- return std::min(context_capabilities.max_transfer_buffer_usage_bytes,
- max_transfer_buffer_usage_bytes);
-}
-
size_t GetDefaultMemoryAllocationLimit() {
// TODO(ccameron): (http://crbug.com/137094) This 64MB default is a straggler
// from the old texture manager and is just to give us a default memory
@@ -259,8 +235,6 @@ LayerTreeHostImpl::LayerTreeHostImpl(
}
DCHECK(proxy_->IsImplThread());
- DCHECK_IMPLIES(settings.use_one_copy, !settings.use_zero_copy);
- DCHECK_IMPLIES(settings.use_zero_copy, !settings.use_one_copy);
DidVisibilityChange(this, visible_);
SetDebugState(settings.initial_debug_state);
@@ -2134,35 +2108,17 @@ void LayerTreeHostImpl::CreateResourceAndTileTaskWorkerPool(
return;
}
- if (settings_.use_one_copy) {
- *resource_pool = ResourcePool::Create(resource_provider_.get(),
- GetTaskRunner(), GL_TEXTURE_2D);
-
- int max_copy_texture_chromium_size =
- context_provider->ContextCapabilities()
- .gpu.max_copy_texture_chromium_size;
-
- *tile_task_worker_pool = OneCopyTileTaskWorkerPool::Create(
- GetTaskRunner(), task_graph_runner, context_provider,
- resource_provider_.get(), max_copy_texture_chromium_size,
- settings_.use_persistent_map_for_gpu_memory_buffers,
- settings_.max_staging_buffers);
- return;
- }
-
- // Synchronous single-threaded mode depends on tiles being ready to
- // draw when raster is complete. Therefore, it must use one of zero
- // copy, software raster, or GPU raster (in the branches above).
- DCHECK(!is_synchronous_single_threaded_);
-
*resource_pool = ResourcePool::Create(resource_provider_.get(),
GetTaskRunner(), GL_TEXTURE_2D);
- *tile_task_worker_pool = PixelBufferTileTaskWorkerPool::Create(
- GetTaskRunner(), task_graph_runner_, context_provider,
- resource_provider_.get(),
- GetMaxTransferBufferUsageBytes(context_provider->ContextCapabilities(),
- settings_.renderer_settings.refresh_rate));
+ int max_copy_texture_chromium_size = context_provider->ContextCapabilities()
+ .gpu.max_copy_texture_chromium_size;
+
+ *tile_task_worker_pool = OneCopyTileTaskWorkerPool::Create(
+ GetTaskRunner(), task_graph_runner, context_provider,
+ resource_provider_.get(), max_copy_texture_chromium_size,
+ settings_.use_persistent_map_for_gpu_memory_buffers,
+ settings_.max_staging_buffers);
}
void LayerTreeHostImpl::RecordMainFrameTiming(
« no previous file with comments | « cc/test/test_gles2_interface.cc ('k') | cc/trees/layer_tree_host_pixeltest_blending.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698