Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1186353003: [turbofan] Fix overzealous reserving of lazy deopt space. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix overzealous reserving of lazy deopt space. This fixes CodeGenerator::EnsureSpaceForLazyDeopt to no longer be treated as a lazy deopt site in itself. Calls mark themselves as lazy bailout sites in CodeGenerator::RecordCallPosition, which suffices. R=jarin@chromium.org Committed: https://crrev.com/d4a74f08d29684ba50362fb78c5a716b1f44e6cb Cr-Commit-Position: refs/heads/master@{#29069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-16 14:32:57 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-06-17 05:11:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186353003/1
5 years, 6 months ago (2015-06-17 07:42:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 07:43:44 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 07:43:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4a74f08d29684ba50362fb78c5a716b1f44e6cb
Cr-Commit-Position: refs/heads/master@{#29069}

Powered by Google App Engine
This is Rietveld 408576698