Add support for `width` based Width Client Hint

Source/core/html/HTMLImageElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 384 matching lines @@
     if (m_listener)
         document().mediaQueryMatcher().removeViewportListener(m_listener);
     HTMLElement::removedFrom(insertionPoint);
 }
 
 int HTMLImageElement::width(bool ignorePendingStylesheets)
 {
     if (!layoutObject()) {
         // check the attribute first for an explicit pixel value
         bool ok;
+        // TODO(yoav): That seems buggy when width is provided with a '%'.

[igrigorik, 2015/06/17 17:26:28]

Per spec, it's CSS px only:
http://www.w3.org/html/wg/drafts/html/master/semantics.html#attr-dim-width

[Mike West, 2015/06/18 06:20:04]

Is there a bug we could point to here?

[Yoav Weiss, 2015/06/18 06:30:22]

I'll open one, once I make sure this is an actual issue.

[Yoav Weiss, 2015/06/18 09:19:27]

Seems to be returning the calculated width after layout and 0 before layout,
which makes sense: http://jsbin.com/bijirekazu/edit?html,console,output
I'll delete the comment.

         int width = getAttribute(widthAttr).toInt(&ok);
         if (ok)
             return width;
 
         // if the image is available, use its width
         if (imageLoader().image())
             return imageLoader().image()->imageSizeForLayoutObject(layoutObject(), 1.0f).width();
     }
 
     if (ignorePendingStylesheets)
@@ skipping 208 matching lines @@
     ImageResource* image = cachedImage();
     if (!image)
         return FloatSize();
     LayoutSize size;
     size = image->imageSizeForLayoutObject(layoutObject(), 1.0f);
     if (layoutObject() && layoutObject()->isLayoutImage() && image->image() && !image->image()->hasRelativeWidth())
         size.scale(toLayoutImage(layoutObject())->imageDevicePixelRatio());
     return FloatSize(size);
 }
 
+static bool sourceSizeValue(Element& element, Document& currentDocument, float& sourceSize)
+{
+    String sizes = element.fastGetAttribute(sizesAttr);
+    bool exists = !sizes.isNull();
+    if (exists)
+        UseCounter::count(currentDocument, UseCounter::Sizes);
+    sourceSize = SizesAttributeParser(MediaValuesDynamic::create(currentDocument), sizes).length();
+    return exists;
+}
+
+int HTMLImageElement::widthAttributeToInt(const String& value, bool& isValid)
+{
+    if (!value.isEmpty() && !value.contains('%') && !value.contains('*'))

[Mike West, 2015/06/18 06:20:04]

Nit: Could you add a comment here explaining why you're excluding '%' and '*'?

[Yoav Weiss, 2015/06/18 06:30:22]

Will do

+        return value.toInt(&isValid);
+
+    isValid = false;
+    return 0;
+}
+
+FetchRequest::ResourceWidth HTMLImageElement::resourceWidth()
+{
+    FetchRequest::ResourceWidth resourceWidth;
+    resourceWidth.isSet = sourceSizeValue(*this, document(), resourceWidth.width);
+    if (!resourceWidth.isSet)
+        resourceWidth.width = widthAttributeToInt(fastGetAttribute(widthAttr), resourceWidth.isSet);
+    return resourceWidth;
+}
+
 float HTMLImageElement::sourceSize(Element& element)
 {
-    String sizes = element.fastGetAttribute(sizesAttr);
-    if (!sizes.isNull())
-        UseCounter::count(document(), UseCounter::Sizes);
-    return SizesAttributeParser(MediaValuesDynamic::create(document()), sizes).length();
+    float value;
+    // We don't care here if the sizes attribute exists, so we ignore the return value.
+    // If it doesn't exist, we just return the default.
+    sourceSizeValue(element, document(), value);
+    return value;
 }
 
 void HTMLImageElement::forceReload() const
 {
     imageLoader().updateFromElement(ImageLoader::UpdateForcedReload);
 }
 
 void HTMLImageElement::selectSourceURL(ImageLoader::UpdateFromElementBehavior behavior)
 {
     if (!document().isActive())
@@ skipping 78 matching lines @@
     ensureUserAgentShadowRoot();
 }
 
 bool HTMLImageElement::isOpaque() const
 {
     Image* image = const_cast<HTMLImageElement*>(this)->imageContents();
     return image && image->currentFrameKnownToBeOpaque();
 }
 
 }