Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1186333002: [turbofan] Work around negative parameter count. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Work around negative parameter count. BUG=chromium:500824 LOG=n R=mstarzinger@chromium.org Committed: https://crrev.com/21a1975542e7abd46db7d2074514eb67a6f525a1 Cr-Commit-Position: refs/heads/master@{#29043}

Patch Set 1 #

Patch Set 2 : Off by one... #

Total comments: 2

Patch Set 3 : Remove bug reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/compiler/typer.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-500824.js View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-16 08:55:20 UTC) #1
Benedikt Meurer
Hey Michi, Quick fix for the negative parameter count. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-16 08:55:52 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1186333002/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/1186333002/diff/20001/src/compiler/typer.cc#newcode2415 src/compiler/typer.cc:2415: // https://code.google.com/p/chromium/issues/detail?id=500824 nit: We probably don't need to ...
5 years, 6 months ago (2015-06-16 09:03:17 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1186333002/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/1186333002/diff/20001/src/compiler/typer.cc#newcode2415 src/compiler/typer.cc:2415: // https://code.google.com/p/chromium/issues/detail?id=500824 On 2015/06/16 09:03:17, Michael Starzinger wrote: > ...
5 years, 6 months ago (2015-06-16 09:04:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186333002/40001
5 years, 6 months ago (2015-06-16 09:04:17 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-16 09:44:29 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 09:44:34 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21a1975542e7abd46db7d2074514eb67a6f525a1
Cr-Commit-Position: refs/heads/master@{#29043}

Powered by Google App Engine
This is Rietveld 408576698